Skip to content

Destination Bigquery: Clean up dependencies with TD/CDK - #34226

Merged
Gireesh Sreepathi (gisripa) merged 5 commits into
masterfrom
gireesh/bigquery/cdk-dep-clean
Jan 12, 2024
Merged

Destination Bigquery: Clean up dependencies with TD/CDK#34226
Gireesh Sreepathi (gisripa) merged 5 commits into
masterfrom
gireesh/bigquery/cdk-dep-clean

Conversation

@gisripa

Copy link
Copy Markdown
Contributor

What

*Using TD from CDK instead of project
*Other minor dependency removed

How

  • Using features capability of cdk to add non-core dependencies.

Signed-off-by: Gireesh Sreepathi <gisripa@gmail.com>
@gisripa
Gireesh Sreepathi (gisripa) requested a review from a team as a code owner January 12, 2024 19:34
@vercel

vercel Bot commented Jan 12, 2024

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Jan 12, 2024 8:45pm

@github-actions

github-actions Bot commented Jan 12, 2024

Copy link
Copy Markdown
Contributor

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@edgao Edward Gao (edgao) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

assuming tests pass

Comment thread airbyte-integrations/connectors/destination-bigquery/build.gradle Outdated
@gisripa

Copy link
Copy Markdown
Contributor Author

assuming tests pass

Failed because the cdk version it depends on didn't have my case-sensitive field fixtures i think.

Signed-off-by: Gireesh Sreepathi <gisripa@gmail.com>
Signed-off-by: Gireesh Sreepathi <gisripa@gmail.com>
Signed-off-by: Gireesh Sreepathi <gisripa@gmail.com>
@gisripa
Gireesh Sreepathi (gisripa) deleted the gireesh/bigquery/cdk-dep-clean branch January 12, 2024 21:04
Joe Bell (jbfbell) pushed a commit that referenced this pull request Jan 12, 2024
Signed-off-by: Gireesh Sreepathi <gisripa@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/connectors Connector related issues area/documentation Improvements or additions to documentation checklist-action-run connectors/destination/bigquery

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants