Skip to content

Destinatino bigquery: update test fixtures - #34575

Merged
Edward Gao (edgao) merged 9 commits into
masterfrom
edgao/dv2/bigquery_tests
Feb 9, 2024
Merged

Destinatino bigquery: update test fixtures#34575
Edward Gao (edgao) merged 9 commits into
masterfrom
edgao/dv2/bigquery_tests

Conversation

@edgao

@edgao Edward Gao (edgao) commented Jan 26, 2024

Copy link
Copy Markdown
Contributor

same as #34574 but for bigquery

@edgao
Edward Gao (edgao) requested a review from a team as a code owner January 26, 2024 19:07
@vercel

vercel Bot commented Jan 26, 2024 •
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Feb 9, 2024 10:11pm

@github-actions

github-actions Bot commented Jan 26, 2024 •
edited by edgao
Loading

Copy link
Copy Markdown
Contributor

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

gisripa
Gireesh Sreepathi (gisripa) approved these changes Jan 29, 2024
View reviewed changes

@gisripa Gireesh Sreepathi (gisripa) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fullRefreshOverwrite failing. I hope that is transient error ?

@edgao

Edward Gao (edgao) commented Jan 29, 2024

Copy link
Copy Markdown
Contributor Author

uhhhhh that's weird. Rerunning CI...

this branch definitely includes the fix to BaseTDTest.endSync from last week, so not really sure why the final table is (apparently) empty 🤔

Base automatically changed from edgao/dv2/special_characters to master February 9, 2024 19:08
@edgao
Merge branch 'master' into edgao/dv2/bigquery_tests
b2210e3 
# Conflicts:
#	airbyte-cdk/java/airbyte-cdk/typing-deduping/src/testFixtures/java/io/airbyte/integrations/base/destination/typing_deduping/BaseTypingDedupingTest.java
#	airbyte-integrations/connectors/destination-bigquery/build.gradle
#	airbyte-integrations/connectors/destination-redshift/src/main/java/io/airbyte/integrations/destination/redshift/operations/RedshiftSqlOperations.java
@octavia-squidington-iii Octavia Squidington III (octavia-squidington-iii) added the area/documentation Improvements or additions to documentation label Feb 9, 2024
@edgao
Edward Gao (edgao) enabled auto-merge (squash) February 9, 2024 21:49
@octavia-squidington-iii Octavia Squidington III (octavia-squidington-iii) removed the CDK Connector Development Kit label Feb 9, 2024
@edgao
Edward Gao (edgao) merged commit 5a1f359 into master Feb 9, 2024
@edgao
Edward Gao (edgao) deleted the edgao/dv2/bigquery_tests branch February 9, 2024 22:22
Xiaohan Song (xiaohansong) pushed a commit that referenced this pull request Feb 13, 2024
@edgao Xiaohan Song
Destination bigquery: update test fixtures (#34575)
a3634fa
Xiaohan Song (xiaohansong) pushed a commit that referenced this pull request Feb 27, 2024
@edgao Xiaohan Song
Destination bigquery: update test fixtures (#34575)
1a72eb4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lazebnyi Serhii Lazebnyi (lazebnyi) lazebnyi approved these changes
+1 more reviewer
@gisripa Gireesh Sreepathi (gisripa) gisripa approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/destination/bigquery connectors/destination/redshift

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@edgao @gisripa @lazebnyi @octavia-squidington-iii