Source S3: updates for compatibility with the concurrent CDK by clnoll · Pull Request #34591 · airbytehq/airbyte

Catherine Noll (clnoll) · 2024-01-28T21:39:52Z

Add catalog, config, and state to the args sent to the source, for compatibility with the concurrent CDK.

Depends on #34411.

vercel · 2024-01-28T21:39:58Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
airbyte-docs	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Feb 5, 2024 2:36pm

github-actions · 2024-01-28T21:40:10Z

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

PR name follows PR naming conventions
Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
Secrets in the connector's spec are annotated with airbyte_secret
All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

Check for hidden checklists in your PR description
Toggle the github label checklist-action-run on/off to re-run the checklist CI.

Alexandre Girard (girarda)

looks good!

Alexandre Girard (girarda) · 2024-01-30T01:03:47Z

is there value in allowing the user to configure the concurrency level?

This is to allow each source to turn on concurrency intentionally, instead of accidentally deploying it when the next version of the connector is deployed.

Maxime Carbonneau-Leclerc (maxi297)

CATs will probably fail until #34605 is available. It is currently blocked by #34653. I'll release as soon as it is approved

Catherine Noll (clnoll) requested a review from a team January 28, 2024 21:39

Octavia Squidington III (octavia-squidington-iii) added area/connectors Connector related issues CDK Connector Development Kit connectors/source/s3 labels Jan 28, 2024

Octavia Squidington IV (octavia-squidington-iv) requested a review from a team January 28, 2024 21:41

Catherine Noll (clnoll) force-pushed the source-s3-fcdk-with-ccdk-full-refresh branch from 57bced5 to 98b7dd8 Compare January 29, 2024 01:32

Catherine Noll (clnoll) requested review from Alexandre Girard (girarda) and Maxime Carbonneau-Leclerc (maxi297) January 29, 2024 01:40

Catherine Noll (clnoll) force-pushed the source-s3-fcdk-with-ccdk-full-refresh branch from 98b7dd8 to 7d7fd18 Compare January 29, 2024 02:50

Octavia Squidington III (octavia-squidington-iii) added the area/documentation Improvements or additions to documentation label Jan 29, 2024

Catherine Noll (clnoll) changed the base branch from master to fcdk-with-ccdk January 29, 2024 02:51

vercel Bot deployed to Preview January 29, 2024 02:52 View deployment

Catherine Noll (clnoll) force-pushed the source-s3-fcdk-with-ccdk-full-refresh branch from 7d7fd18 to 532cc10 Compare January 29, 2024 02:53

Catherine Noll (clnoll) changed the base branch from fcdk-with-ccdk to master January 29, 2024 02:54

Octavia Squidington III (octavia-squidington-iii) removed the CDK Connector Development Kit label Jan 29, 2024

vercel Bot deployed to Preview January 29, 2024 02:55 View deployment

Catherine Noll (clnoll) force-pushed the source-s3-fcdk-with-ccdk-full-refresh branch from 532cc10 to 2ce72b5 Compare January 30, 2024 00:53

vercel Bot deployed to Preview January 30, 2024 00:55 View deployment

Alexandre Girard (girarda) approved these changes Jan 30, 2024

View reviewed changes

Octavia Squidington III (octavia-squidington-iii) added the CDK Connector Development Kit label Jan 30, 2024

Catherine Noll (clnoll) force-pushed the source-s3-fcdk-with-ccdk-full-refresh branch from 17a7c5e to 2b188f8 Compare January 30, 2024 01:37

vercel Bot deployed to Preview January 30, 2024 01:38 View deployment

Catherine Noll (clnoll) force-pushed the source-s3-fcdk-with-ccdk-full-refresh branch from 2b188f8 to ed7947a Compare January 30, 2024 02:05

Octavia Squidington III (octavia-squidington-iii) removed the CDK Connector Development Kit label Jan 30, 2024

vercel Bot deployed to Preview January 30, 2024 02:07 View deployment

Catherine Noll (clnoll) force-pushed the source-s3-fcdk-with-ccdk-full-refresh branch from ed7947a to 59fb0e2 Compare January 30, 2024 03:53

Octavia Squidington III (octavia-squidington-iii) added the CDK Connector Development Kit label Jan 30, 2024

Catherine Noll (clnoll) force-pushed the source-s3-fcdk-with-ccdk-full-refresh branch from 59fb0e2 to a7e2ee2 Compare January 30, 2024 04:33

Maxime Carbonneau-Leclerc (maxi297) reviewed Jan 30, 2024

View reviewed changes

Catherine Noll (clnoll) requested a review from a team January 30, 2024 15:42

Catherine Noll (clnoll) requested a review from a team as a code owner January 30, 2024 15:42

Catherine Noll (clnoll) force-pushed the source-s3-fcdk-with-ccdk-full-refresh branch from 90fe619 to 16db127 Compare January 30, 2024 16:14

Octavia Squidington III (octavia-squidington-iii) removed CDK Connector Development Kit area/documentation Improvements or additions to documentation labels Jan 30, 2024

Catherine Noll (clnoll) force-pushed the source-s3-fcdk-with-ccdk-full-refresh branch from 16db127 to 87d61e3 Compare January 30, 2024 16:19

Octavia Squidington III (octavia-squidington-iii) added the area/documentation Improvements or additions to documentation label Jan 30, 2024

Catherine Noll (clnoll) force-pushed the source-s3-fcdk-with-ccdk-full-refresh branch from 87d61e3 to 776bf56 Compare January 30, 2024 16:21

vercel Bot deployed to Preview January 30, 2024 16:23 View deployment

Catherine Noll (clnoll) force-pushed the source-s3-fcdk-with-ccdk-full-refresh branch from 776bf56 to 40ef2da Compare January 30, 2024 20:26

vercel Bot deployed to Preview January 30, 2024 20:27 View deployment

Catherine Noll (clnoll) force-pushed the source-s3-fcdk-with-ccdk-full-refresh branch from 40ef2da to 48b8f83 Compare January 31, 2024 13:49

vercel Bot deployed to Preview January 31, 2024 13:52 View deployment

Catherine Noll (clnoll) force-pushed the source-s3-fcdk-with-ccdk-full-refresh branch from df35244 to 998f28a Compare February 1, 2024 17:56

vercel Bot deployed to Preview February 1, 2024 18:02 View deployment

Catherine Noll (clnoll) force-pushed the source-s3-fcdk-with-ccdk-full-refresh branch from 998f28a to c4ae774 Compare February 1, 2024 19:37

vercel Bot deployed to Preview February 1, 2024 19:39 View deployment

Source S3: run full refresh syncs concurrently

958e659

Catherine Noll (clnoll) force-pushed the source-s3-fcdk-with-ccdk-full-refresh branch from c4ae774 to 958e659 Compare February 5, 2024 14:34

vercel Bot deployed to Preview February 5, 2024 14:36 View deployment

Catherine Noll (clnoll) merged commit 53d71f9 into master Feb 5, 2024

Catherine Noll (clnoll) deleted the source-s3-fcdk-with-ccdk-full-refresh branch February 5, 2024 15:01

Pedro S. Lopez (pedroslopez) mentioned this pull request Feb 6, 2024

source-s3: pin to version 4.4.1 #34926

Merged

Xiaohan Song (xiaohansong) pushed a commit that referenced this pull request Feb 13, 2024

Source S3: updates for compatibility with the concurrent CDK (#34591)

dfe4431

Xiaohan Song (xiaohansong) pushed a commit that referenced this pull request Feb 27, 2024

Source S3: updates for compatibility with the concurrent CDK (#34591)

7675657

Navigation Menu

Repository navigation

Source S3: updates for compatibility with the concurrent CDK - #34591

Source S3: updates for compatibility with the concurrent CDK#34591
Catherine Noll (clnoll) merged 1 commit into
masterfrom
source-s3-fcdk-with-ccdk-full-refresh

Catherine Noll (clnoll) commented Jan 28, 2024

Uh oh!

vercel Bot commented Jan 28, 2024 •

edited

Loading

Uh oh!

github-actions Bot commented Jan 28, 2024 •

edited by clnoll

Loading

Uh oh!

Alexandre Girard (girarda) left a comment

Uh oh!

Alexandre Girard (girarda) Jan 30, 2024

Uh oh!

Catherine Noll (clnoll) Jan 30, 2024

Uh oh!

Maxime Carbonneau-Leclerc (maxi297) left a comment

Uh oh!

This branch was successfully deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

Catherine Noll (clnoll) commented Jan 28, 2024

Uh oh!

vercel Bot commented Jan 28, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jan 28, 2024 • edited by clnoll Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Before Merging a Connector Pull Request

Uh oh!

Alexandre Girard (girarda) left a comment

Choose a reason for hiding this comment

Uh oh!

Alexandre Girard (girarda) Jan 30, 2024

Choose a reason for hiding this comment

Uh oh!

Catherine Noll (clnoll) Jan 30, 2024

Choose a reason for hiding this comment

Uh oh!

Maxime Carbonneau-Leclerc (maxi297) left a comment

Choose a reason for hiding this comment

Uh oh!

This branch was successfully deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

vercel Bot commented Jan 28, 2024 •

edited

Loading

github-actions Bot commented Jan 28, 2024 •

edited by clnoll

Loading