async-destination-framework: make GlobalAsyncStateManager entirely thread safe - #35027
Merged
Subodh Chaturvedi (subodh1810) merged 8 commits intoFeb 8, 2024
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Octavia Squidington III (octavia-squidington-iii)
added
the
CDK
Subodh Chaturvedi (subodh1810)
requested a review
from a team
as a code owner
February 8, 2024 17:07
Octavia Squidington III (octavia-squidington-iii)
added
area/connectors
Contributor
Author
|
Snowflake tests passing with these changes Bigquery tests passing with these changes |
Subodh Chaturvedi (subodh1810)
requested review from
Edward Gao (edgao) and
Gireesh Sreepathi (gisripa)
February 8, 2024 17:54
Edward Gao (edgao)
left a comment
Edward Gao (edgao)
left a comment
Contributor
There was a problem hiding this comment.
couple random questions, see also dm
Gireesh Sreepathi (gisripa)
approved these changes
Feb 8, 2024
Gireesh Sreepathi (gisripa)
left a comment
Gireesh Sreepathi (gisripa)
left a comment
Contributor
There was a problem hiding this comment.
lookout for Ed's PR; possible merge conflict in SnowflakeDestinationHandler.
Edward Gao (edgao)
approved these changes
Feb 8, 2024
| // All access to this field MUST be guarded by a synchronized(lock) block | ||
| private long arrivalNumber = 0; | ||
|
|
||
| private final Object lock = new Object(); |
Contributor
There was a problem hiding this comment.
nit: allcaps constant name
Contributor
Author
|
/publish-java-cdk
|
Octavia Squidington III (octavia-squidington-iii)
added
the
area/documentation
Subodh Chaturvedi (subodh1810)
deleted the
make-global-async-state-manager-thread-safe
branch
February 8, 2024 21:16
Xiaohan Song (xiaohansong)
pushed a commit
that referenced
this pull request
Feb 13, 2024
Xiaohan Song (xiaohansong)
pushed a commit
that referenced
this pull request
Feb 27, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See slack thread https://airbytehq-team.slack.com/archives/C0624HL9UTU/p1707392863771999?thread_ts=1707315038.780149&cid=C0624HL9UTU
The main change in the PR is to
LinkedListused in thedescToStateIdQtoLinkedBlockingDequecause LinkedList is not thread safe.arrivalNumberfor logging purposes so thats its easier to debug if the destination is emitting state messages in the same order as they arrived for GLOBAL state type