add entry into JAVA_OPTS to always select log4j2.xml as our logger configuration - #35569
Merged
Conversation
Stephane Geneix (stephane-airbyte)
requested a review
from a team
as a code owner
February 23, 2024 02:08
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
Contributor
Author
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join Stephane Geneix (@stephane-airbyte) and the rest of your teammates on |
Xiaohan Song (xiaohansong)
approved these changes
Feb 23, 2024
Marius Posta (postamar)
left a comment
Marius Posta (postamar)
left a comment
Contributor
There was a problem hiding this comment.
Check that this doesn't screw up the logging during integration tests before merging please.
Marius Posta (postamar)
approved these changes
Feb 23, 2024
Marius Posta (postamar)
left a comment
Marius Posta (postamar)
left a comment
Contributor
There was a problem hiding this comment.
I checked and this seems to work. When building a connector image using the assemble gradle task, the log messages printed when we call SPEC as a sanity check are json with this PR and textual on master.
This was referenced Feb 23, 2024
Marius Posta (postamar)
deleted the
stephane/02-22-add_entry_into_JAVA_OPTS_to_always_select_log4j2.xml_as_our_logger_configuration
branch
February 23, 2024 03:37
Marius Posta (postamar)
pushed a commit
that referenced
this pull request
Feb 23, 2024
Marius Posta (postamar)
pushed a commit
that referenced
this pull request
Feb 23, 2024
Marius Posta (postamar)
pushed a commit
that referenced
this pull request
Feb 23, 2024
Marius Posta (postamar)
pushed a commit
that referenced
this pull request
Feb 23, 2024
Marius Posta (postamar)
pushed a commit
that referenced
this pull request
Feb 23, 2024
Marius Posta (postamar)
pushed a commit
that referenced
this pull request
Feb 23, 2024
Tanawat Panmongkol (tanawatpan)
pushed a commit
to tanawatpan/airbyte
that referenced
this pull request
Feb 24, 2024
Tanawat Panmongkol (tanawatpan)
pushed a commit
to tanawatpan/airbyte
that referenced
this pull request
Feb 24, 2024
…hq#35576) Co-authored-by: Stephane Geneix <stephane@airbyte.io>
Tanawat Panmongkol (tanawatpan)
pushed a commit
to tanawatpan/airbyte
that referenced
this pull request
Feb 24, 2024
…irbytehq#35575) Co-authored-by: Stephane Geneix <stephane@airbyte.io>
Tanawat Panmongkol (tanawatpan)
pushed a commit
to tanawatpan/airbyte
that referenced
this pull request
Feb 24, 2024
…irbytehq#35574) Co-authored-by: Stephane Geneix <stephane@airbyte.io>
Tanawat Panmongkol (tanawatpan)
pushed a commit
to tanawatpan/airbyte
that referenced
this pull request
Feb 24, 2024
…#35573) Co-authored-by: Stephane Geneix <stephane@airbyte.io>
Tanawat Panmongkol (tanawatpan)
pushed a commit
to tanawatpan/airbyte
that referenced
this pull request
Feb 24, 2024
…ehq#35572) Co-authored-by: Stephane Geneix <stephane@airbyte.io>
Tanawat Panmongkol (tanawatpan)
pushed a commit
to tanawatpan/airbyte
that referenced
this pull request
Feb 24, 2024
…ytehq#35571) Co-authored-by: Stephane Geneix <stephane@airbyte.io>
Xiaohan Song (xiaohansong)
pushed a commit
that referenced
this pull request
Feb 27, 2024
Xiaohan Song (xiaohansong)
pushed a commit
that referenced
this pull request
Feb 27, 2024
Xiaohan Song (xiaohansong)
pushed a commit
that referenced
this pull request
Feb 27, 2024
Xiaohan Song (xiaohansong)
pushed a commit
that referenced
this pull request
Feb 27, 2024
Xiaohan Song (xiaohansong)
pushed a commit
that referenced
this pull request
Feb 27, 2024
Xiaohan Song (xiaohansong)
pushed a commit
that referenced
this pull request
Feb 27, 2024
Xiaohan Song (xiaohansong)
pushed a commit
that referenced
this pull request
Feb 27, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.