Fix error message for saved offset not valid. - #35675
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Octavia Squidington III (octavia-squidington-iii)
added
area/connectors
Akash Kulkarni (akashkulk)
requested a review
from Rodi Reich Zilberman (rodireich)
February 27, 2024 21:13
Rodi Reich Zilberman (rodireich)
approved these changes
Feb 27, 2024
Octavia Squidington III (octavia-squidington-iii)
added
the
area/documentation
Akash Kulkarni (akashkulk)
marked this pull request as ready for review
February 27, 2024 21:18
Akash Kulkarni (akashkulk)
enabled auto-merge (squash)
February 27, 2024 21:19
| if (config.shouldFailSyncOnInvalidCursor()) { | ||
| throw new ConfigErrorException( | ||
| "Saved offset is not valid. Please reset the connection, and then increase oplog retention or reduce sync frequency to prevent his from happening in the future. See https://docs.airbyte.com/integrations/sources/mongodb-v2#mongodb-oplog-and-change-streams for more details"); | ||
| "Saved offset is not valid. Please reset the connection, and then increase oplog retention and/or increase sync frequency to prevent his from happening in the future. See https://docs.airbyte.com/integrations/sources/mongodb-v2#mongodb-oplog-and-change-streams for more details"); |
Contributor
There was a problem hiding this comment.
Question: I have a bunch of tables which are rarely used but we use Airbyte to sync them.
By definition, these tables will have an outdated oplog resume token that would not exist.
Shouldnt the expected behaviour be trigerring a full rebuild in that case?
Contributor
Author
There was a problem hiding this comment.
An oplog resume token being rotated out can lead to data loss since deletes aren't properly captured. In addition, it can lead to higher cloud costs due to consumption of credits.
If you do want to rebuild you can :
- Move the tables that are rarely used to a new connection.
- In that connection, you change the invalid cdc cursor behavior to "Re-sync Data". This will change it to the previous behavior of rebuilding
Contributor
There was a problem hiding this comment.
The definition was in the source and not in the connection 😜
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
s/reduce sync frequency/increase sync frequency