Destinatoin snowflake: Add config option to enable time travel - #35754
Merged
Edward Gao (edgao) merged 6 commits intoApr 10, 2024
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
Octavia Squidington III (octavia-squidington-iii)
added
area/connectors
Contributor
|
I would vote for 1-day retention on all tables as the default, but that's a soft prefrence. |
Contributor
Author
|
sold on 1 day by default. I don't particularly want to write a migration for |
Joe Bell (jbfbell)
approved these changes
Mar 4, 2024
Octavia Squidington III (octavia-squidington-iii)
added
the
area/documentation
Edward Gao (edgao)
enabled auto-merge (squash)
April 8, 2024 16:57
Edward Gao (edgao)
deleted the
edgao/snowflake/configurable_retention_period
branch
April 10, 2024 19:54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #21879
... also sets the retention period on the final tables, where previously we weren't. I could see an argument that - since we've been using the default (1 day) since dv2 release, that we should actually default to 1 day everywhere? but either way, wanted to get the bones of the PR out for review + trigger CI.