Repository navigation
[source-mssql] mssql use SourceStateIterator to send out counts - #35792
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
various small changes related to tests and mssql: the jdbc string for MSSQL was wrong. The LoggingInterceptor was printing faulty log lines The SSHBastionContainer should be a container like any other, relying upon the ContainerFactory. As a result, the ContainerFactory should be able to return any type of container, not just JdbcDatabaseContainer. In addition, we shouldn't be passing strings to the ContainerFactory as container modifiers, but a named lambda. No more introspection needed! (the old string-based is kept for backward compatibility) The CdcSourceTest doesn't check DB invariants before starting a source. We need a test function that can be overriden by the implementations of CdcSourceTest
Signed-off-by: Gireesh Sreepathi <gisripa@gmail.com> Co-authored-by: Gireesh Sreepathi <gisripa@gmail.com>
…V file (#35313) Co-authored-by: Gireesh Sreepathi <gisripa@gmail.com>
Today there's no clear timeout for tests. The only one that exists is at the github action level, and it has to be conservative at 1h. This change introduces a timeout per test method. The default value is set at 5 minutes per method, and can be overriden on a per method basis via the use of the junit @timeout annotation. We're also fixing a regression in the test ContainerFactory that was sharing less container than was possible. Finally, we're introducing a MdcScope.doNothing to allow using MdcScope in try blocks without triggering a compiler warning
| } | ||
|
|
||
| @Override | ||
| protected void assertExpectedStateMessageCountMatches(final List<AirbyteStateMessage> stateMessages, long totalCount) { |
Contributor
There was a problem hiding this comment.
Is this now enabled for all of our certified connectors? If so, we can just remove all of the overrides and enable in the base class
Contributor
Author
There was a problem hiding this comment.
yep! I'm planning to do that in the next PR.
|
|
||
| airbyteJavaConnector { | ||
| cdkVersionRequired = '0.23.15' | ||
| cdkVersionRequired = '0.23.17' |
Contributor
There was a problem hiding this comment.
Any reason to bump up the cdk version? or just bumping to latest?
Contributor
Author
There was a problem hiding this comment.
yes - bumping to the latest so the new iterator interface introduced a few PRs ago can be used
Akash Kulkarni (akashkulk)
approved these changes
Mar 13, 2024
Akash Kulkarni (akashkulk)
left a comment
Contributor
There was a problem hiding this comment.
Have some minor commnets, nothing major
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Make Ms-sql use SourceStateIterator to send out state messages.
How
Describe the solution
Recommended reading order
x.javay.python🚨 User Impact 🚨
Are there any breaking changes? What is the end result perceived by the user?
For connector PRs, use this section to explain which type of semantic versioning bump occurs as a result of the changes. Refer to our Semantic Versioning for Connectors guidelines for more information. Breaking changes to connectors must be documented by an Airbyte engineer (PR author, or reviewer for community PRs) by using the Breaking Change Release Playbook.
If there are breaking changes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.
Pre-merge Actions
Expand the relevant checklist and delete the others.
New Connector
Community member or Airbyter
./gradlew :airbyte-integrations:connectors:<name>:integrationTest.0.0.1Dockerfilehas version0.0.1README.mdbootstrap.md. See description and examplesdocs/integrations/<source or destination>/<name>.mdincluding changelog with an entry for the initial version. See changelog exampledocs/integrations/README.mdAirbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
Updating a connector
Community member or Airbyter
Airbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
Connector Generator
-scaffoldin their name) have been updated with the latest scaffold by running./gradlew :airbyte-integrations:connector-templates:generator:generateScaffoldsthen checking in your changesUpdating the Python CDK
Airbyter
Before merging:
--use-local-cdk --name=source-<connector>as optionsairbyte-ci connectors --use-local-cdk --name=source-<connector> testAfter merging: