Skip to content

make query safer for servers that are case sensitive - #35816

Merged
Stephane Geneix (stephane-airbyte) merged 2 commits into
masterfrom
rodi/mssql-query-case-sensitive
Mar 6, 2024
Merged

Stephane Geneix (stephane-airbyte) merged 2 commits into
masterfrom
rodi/mssql-query-case-sensitive

Conversation

@rodireich

Copy link
Copy Markdown
Contributor

What

The query we use to check for whether an LSN is still on server was declaring a variable in one letter case (@min_lsn) but was using it with another case (@MIN_LSN).
SQL Server can be turned to interpret queries with case sensitivity (default is case insensitive).

How

Correct the query to make it safer.

@vercel

vercel Bot commented Mar 5, 2024 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 6, 2024 5:16pm

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3.7.6 because .5 already exists in #35739

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, we're going to simplify this ridiculousness :)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not blocking but I think we might need a test for this

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would rather simplify this into a SELECT MIN(start_lsn), max(start_lsn) FROM cdc_change_tables; and do the business logic in java, if possible

Stephane Geneix (stephane-airbyte) commented Mar 5, 2024 •

Copy link
Copy Markdown
Contributor

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join Rodi Reich Zilberman (@rodireich) and the rest of your teammates on Graphite Graphite

@stephane-airbyte
Stephane Geneix (stephane-airbyte) changed the base branch from master to 21498-source-mssql-cdc-job-is-getting-failed-due-to-oom-error March 5, 2024 21:28
@stephane-airbyte
Stephane Geneix (stephane-airbyte) force-pushed the 21498-source-mssql-cdc-job-is-getting-failed-due-to-oom-error branch from 5be001c to 2fa69df Compare March 5, 2024 21:43
@stephane-airbyte
Stephane Geneix (stephane-airbyte) force-pushed the 21498-source-mssql-cdc-job-is-getting-failed-due-to-oom-error branch from 2fa69df to d386a4e Compare March 5, 2024 21:48
@stephane-airbyte
Stephane Geneix (stephane-airbyte) force-pushed the 21498-source-mssql-cdc-job-is-getting-failed-due-to-oom-error branch 2 times, most recently from 74fda84 to a48a677 Compare March 5, 2024 23:33
Base automatically changed from 21498-source-mssql-cdc-job-is-getting-failed-due-to-oom-error to master March 6, 2024 00:45

This branch was successfully deployed

1 active deployment
Preview — 9aa81df3 Deployed Mar 6, 2024 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/mssql

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants