Repository navigation
make query safer for servers that are case sensitive - #35816
Merged
Stephane Geneix (stephane-airbyte) merged 2 commits intoMar 6, 2024
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Rodi Reich Zilberman (rodireich)
marked this pull request as ready for review
March 5, 2024 17:08
Contributor
Author
There was a problem hiding this comment.
3.7.6 because .5 already exists in #35739
Contributor
There was a problem hiding this comment.
yeah, we're going to simplify this ridiculousness :)
Contributor
There was a problem hiding this comment.
not blocking but I think we might need a test for this
Contributor
There was a problem hiding this comment.
I would rather simplify this into a SELECT MIN(start_lsn), max(start_lsn) FROM cdc_change_tables; and do the business logic in java, if possible
Xiaohan Song (xiaohansong)
approved these changes
Mar 5, 2024
Stephane Geneix (stephane-airbyte)
force-pushed
the
rodi/mssql-query-case-sensitive
branch
from
March 5, 2024 21:26
49dd38f to
ef99504
Compare
Contributor
This stack of pull requests is managed by Graphite. Learn more about stacking. Join Rodi Reich Zilberman (@rodireich) and the rest of your teammates on |
Stephane Geneix (stephane-airbyte)
force-pushed
the
rodi/mssql-query-case-sensitive
branch
from
March 5, 2024 21:28
ef99504 to
99782ed
Compare
Stephane Geneix (stephane-airbyte)
changed the base branch from
master
to
21498-source-mssql-cdc-job-is-getting-failed-due-to-oom-error
March 5, 2024 21:28
Stephane Geneix (stephane-airbyte)
force-pushed
the
21498-source-mssql-cdc-job-is-getting-failed-due-to-oom-error
branch
from
March 5, 2024 21:43
5be001c to
2fa69df
Compare
Stephane Geneix (stephane-airbyte)
force-pushed
the
21498-source-mssql-cdc-job-is-getting-failed-due-to-oom-error
branch
from
March 5, 2024 21:48
2fa69df to
d386a4e
Compare
Stephane Geneix (stephane-airbyte)
force-pushed
the
rodi/mssql-query-case-sensitive
branch
from
March 5, 2024 21:48
99782ed to
83d423e
Compare
Stephane Geneix (stephane-airbyte)
force-pushed
the
21498-source-mssql-cdc-job-is-getting-failed-due-to-oom-error
branch
2 times, most recently
from
March 5, 2024 23:33
74fda84 to
a48a677
Compare
Base automatically changed from
21498-source-mssql-cdc-job-is-getting-failed-due-to-oom-error
to
master
March 6, 2024 00:45
Stephane Geneix (stephane-airbyte)
force-pushed
the
rodi/mssql-query-case-sensitive
branch
from
March 6, 2024 00:50
83d423e to
c5d9433
Compare
Stephane Geneix (stephane-airbyte)
force-pushed
the
rodi/mssql-query-case-sensitive
branch
from
March 6, 2024 17:11
c5d9433 to
9aa81df
Compare
Stephane Geneix (stephane-airbyte)
enabled auto-merge (squash)
March 6, 2024 17:15
Stephane Geneix (stephane-airbyte)
deleted the
rodi/mssql-query-case-sensitive
branch
March 6, 2024 17:47
Xiaohan Song (xiaohansong)
pushed a commit
that referenced
this pull request
Mar 7, 2024
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

What
The query we use to check for whether an LSN is still on server was declaring a variable in one letter case (
@min_lsn) but was using it with another case (@MIN_LSN).SQL Server can be turned to interpret queries with case sensitivity (default is case insensitive).
How
Correct the query to make it safer.