[source-postgres] : Add retries back to the DBZ connector - #35904
Merged
Akash Kulkarni (akashkulk) merged 19 commits intoMar 11, 2024
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
Octavia Squidington III (octavia-squidington-iii)
added
area/connectors
Octavia Squidington III (octavia-squidington-iii)
removed
the
area/documentation
Akash Kulkarni (akashkulk)
marked this pull request as ready for review
March 11, 2024 21:13
Akash Kulkarni (akashkulk)
requested a review
from Rodi Reich Zilberman (rodireich)
March 11, 2024 21:14
| // The maximum number of retries on connection errors before failing (-1 = no limit, 0 = disabled, > | ||
| // 0 = num of retries). | ||
| props.setProperty("errors.max.retries", "0"); | ||
| props.setProperty("errors.max.retries", "5"); |
Contributor
There was a problem hiding this comment.
I get that 5 is totally arbitrary, and is more than 0. Maybe this should be a constant that can be overridden by ENV if needed?
Contributor
Author
There was a problem hiding this comment.
Totally arbitrary. Is there a quick/lightweight way to override this via env?
Ideally wanted to avoid exposing this and other things that are debezium properties elsewhere (whether in the config/env etc)
Evan Tahler (evantahler)
approved these changes
Mar 11, 2024
Rodi Reich Zilberman (rodireich)
approved these changes
Mar 11, 2024
Contributor
Author
|
/publish-java-cdk
|
Octavia Squidington III (octavia-squidington-iii)
added
the
area/documentation
Contributor
Author
|
/publish-java-cdk
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.