remove snowflake query timeout - #36452
Merged
Joe Bell (jbfbell) merged 1 commit intoMar 25, 2024
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Octavia Squidington III (octavia-squidington-iii)
added
the
area/connectors
Contributor
Author
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join Joe Bell (@jbfbell) and the rest of your teammates on |
Joe Bell (jbfbell)
force-pushed
the
jbfbell/remove_snowflake_query_timeout
branch
from
March 25, 2024 16:50
b608a19 to
2e7d725
Compare
Octavia Squidington III (octavia-squidington-iii)
added
the
area/documentation
Edward Gao (edgao)
approved these changes
Mar 25, 2024
Edward Gao (edgao)
left a comment
Edward Gao (edgao)
left a comment
Contributor
There was a problem hiding this comment.
🔥
happy to ship as-is, wondering if we should expose this as a config option eventually
Contributor
Author
Edward Gao (@edgao) agreed - supposedly a user could configure this via the JDBC url params but its probably worth verifying |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have provided a snowflake query timeout of 3 hours which users are running into for large or long running syncs. Removing this query timeout so queries will wait indefinitely.