Repository navigation
🐛 Source Salesforce: Update CDK version to have partitioned state fix and add tests - #37392
Merged
Maxime Carbonneau-Leclerc (maxi297) merged 3 commits intoApr 18, 2024
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
Maxime Carbonneau-Leclerc (maxi297)
requested a review
from Alexandre Girard (girarda)
April 18, 2024 03:51
Octavia Squidington III (octavia-squidington-iii)
added
area/connectors
Octavia Squidington III (octavia-squidington-iii)
added
the
area/documentation
Alexandre Girard (girarda)
approved these changes
Apr 18, 2024
Alexandre Girard (girarda)
left a comment
Alexandre Girard (girarda)
left a comment
Collaborator
There was a problem hiding this comment.
thanks for fixing👨⚕️
Maxime Carbonneau-Leclerc (maxi297)
deleted the
maxi297/update_salesforce_with_partitioned_state_fix
branch
April 18, 2024 04:45
Erick Corona (strosek)
pushed a commit
that referenced
this pull request
Apr 24, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Following some testing, we found out that partitioned states were always saved even if the partition wasn't successful. The fix was implemented in the CDK
How
Up the CDK version and add tests.
test_given_slice_fails_when_read_then_state_is_partitionedwas failing before the change and is now passing.User Impact
This should fix the bug. We will contact customers with syncs that had issues to propose a reset to them.
Can this PR be safely reverted and rolled back?