Only check sourcedefined pk for eligibility of rfr - #38046
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Octavia Squidington III (octavia-squidington-iii)
added
area/connectors
Xiaohan Song (xiaohansong)
requested a review
from Rodi Reich Zilberman (rodireich)
May 7, 2024 20:36
Octavia Squidington III (octavia-squidington-iii)
added
the
area/documentation
Rodi Reich Zilberman (rodireich)
approved these changes
May 7, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
In mysql code base for incremental syncs we only refer to SourceDefinedPK for pk related operations. We should use that as eligibility of RFR.
How
Review guide
User Impact
Can this PR be safely reverted and rolled back?