Skip to content

source-mssql: fix cursor value query - #38292

Merged
Marius Posta (postamar) merged 4 commits into
masterfrom
postamar/source-mssql-fix-cursor-query
May 30, 2024
Merged

Marius Posta (postamar) merged 4 commits into
masterfrom
postamar/source-mssql-fix-cursor-query

Conversation

@postamar

@postamar Marius Posta (postamar) commented May 16, 2024 •

Copy link
Copy Markdown
Contributor

What

Fixes airbytehq/airbyte-internal-issues#7772

How

Changes a SQL query to return only one row.

User Impact

Might reduce OOMs, otherwise nothing.

Can this PR be safely reverted and rolled back?

  • YES 💚
  • NO ❌

@vercel

vercel Bot commented May 16, 2024 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 30, 2024 1:42pm

@postamar
Marius Posta (postamar) marked this pull request as ready for review May 16, 2024 19:14
@postamar
Marius Posta (postamar) requested a review from a team as a code owner May 16, 2024 19:14
@postamar

Copy link
Copy Markdown
Contributor Author

Thanks for the review! Updating this PR with a recent master before merging, just to make sure, as this has grown a bit stale.

@postamar
Marius Posta (postamar) force-pushed the postamar/source-mssql-fix-cursor-query branch from b70f727 to 870a19a Compare May 30, 2024 13:38
@postamar
Marius Posta (postamar) merged commit 25db2e0 into master May 30, 2024
@postamar
Marius Posta (postamar) deleted the postamar/source-mssql-fix-cursor-query branch May 30, 2024 14:26

This branch was successfully deployed

1 active deployment
Preview — 870a19aa Deployed May 30, 2024 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/mssql

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants