Salesforce refactor: add CheckpointMixin for state management - #39517
Merged
Cristina Mariscal (cmm-airbyte) merged 2 commits intoJun 17, 2024
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Octavia Squidington III (octavia-squidington-iii)
added
area/connectors
|
cristina.mariscal seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Cristina Mariscal (cmm-airbyte)
marked this pull request as ready for review
June 17, 2024 13:39
Baz (bazarnov)
approved these changes
Jun 17, 2024
Cristina Mariscal (cmm-airbyte)
deleted the
cmm-airbyte/SalesforceCheckpointMixin
branch
June 17, 2024 21:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds the CheckpointMixin to incremental Python streams for source Salesforce and converts existing
get_updated_stateto a private method that gets invoked by the state setter.Resolves #39331
User Impact
No impact foreseen. Link to live test results here
Can this PR be safely reverted and rolled back?