Validate error handler fallback - #40570
Merged
Maxime Carbonneau-Leclerc (maxi297) merged 2 commits intoJun 27, 2024
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
Octavia Squidington III (octavia-squidington-iii)
added
the
CDK
Serhii Lazebnyi (lazebnyi)
approved these changes
Jun 27, 2024
Maxime Carbonneau-Leclerc (maxi297)
deleted the
maxi297/validate-error-handler-fallback
branch
June 27, 2024 21:03
Xiaohan Song (xiaohansong)
pushed a commit
that referenced
this pull request
Jul 9, 2024
Co-authored-by: Serhii Lazebnyi <serhii.lazebnyi@globallogic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Validate that the error handler fallback on the default mapping if it does not hit any status code
How
Adding a test. The reason it works if because of this code that gets executed as part of the DefaultErrorHandler when there is not match
User Impact
None, it's just a test
Can this PR be safely reverted and rolled back?