Repository navigation
🎉 Source Facebook-Marketing: Use latest CDK version possible - #40645
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
Octavia Squidington III (octavia-squidington-iii)
added
area/connectors
Baz (bazarnov)
marked this pull request as ready for review
July 1, 2024 12:36
Octavia Squidington III (octavia-squidington-iii)
added
the
area/documentation
Daryna Ishchenko (darynaishchenko)
approved these changes
Jul 1, 2024
Contributor
Author
|
Maxime Carbonneau-Leclerc (@maxi297) The logic of the |
Contributor
|
Note that there might be this too to take into account |
…ting/use-latest-cdk
Contributor
Author
I'm not sure I understood your point or where this is used within Facebook-Marketing's integration tests.` Could you please specify how this impacts the integration tests? |
added 2 commits
July 4, 2024 17:39
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Resolving:
How
spec.pyto import references frompydantic.v1to preserve the structure of thespecCan this PR be safely reverted and rolled back?