Repository navigation
Revert "Revert "[source-postgres] Fix duplicate streams in postgres"" - #41067
Merged
Xiaohan Song (xiaohansong) merged 3 commits intoJul 9, 2024
Merged
Xiaohan Song (xiaohansong) merged 3 commits into
Xiaohan Song (xiaohansong) merged 3 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Octavia Squidington III (octavia-squidington-iii)
added
area/connectors
Xiaohan Song (xiaohansong)
requested a review
from Rodi Reich Zilberman (rodireich)
July 9, 2024 17:44
Xiaohan Song (xiaohansong)
marked this pull request as ready for review
July 9, 2024 17:44
Rodi Reich Zilberman (rodireich)
approved these changes
Jul 9, 2024
| } | ||
|
|
||
| private boolean isIncrementalStream(final AirbyteStreamNameNamespacePair pair) { | ||
| return !resumableFullRefreshStreams.contains(pair) && !nonResumableFullRefreshStreams.contains(pair); |
Contributor
There was a problem hiding this comment.
Thanks for adding this function!
Could we have one line of comment here to explain this?
Xiaohan Song (xiaohansong)
deleted the
revert-40757-revert-40719-xiaohan/statefix
branch
July 9, 2024 21:09
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #40757
This time I addressed the NPE error.