Skip to content

Fix for nullable top-level schemas - #44401

Merged
Johnny Schmidt (johnny-schmidt) merged 7 commits into
masterfrom
issue-6269/destination-s3-respects-nullable-top-level-schema
Aug 19, 2024
Merged

Fix for nullable top-level schemas#44401
Johnny Schmidt (johnny-schmidt) merged 7 commits into
masterfrom
issue-6269/destination-s3-respects-nullable-top-level-schema

Conversation

@johnny-schmidt

@johnny-schmidt Johnny Schmidt (johnny-schmidt) commented Aug 19, 2024

Copy link
Copy Markdown
Contributor

@vercel

vercel Bot commented Aug 19, 2024 •
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Aug 19, 2024 10:49pm

evantahler
Evan Tahler (evantahler) approved these changes Aug 19, 2024
View reviewed changes

@evantahler Evan Tahler (evantahler) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
You'll need to bump the connector version & docs too

edgao
Edward Gao (edgao) reviewed Aug 19, 2024
View reviewed changes

@edgao Edward Gao (edgao) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

blegh. if you have an easy way to test - what happens if the top-level schema is type: [string, object]? (we've seen that in the past also)

@johnny-schmidt

Johnny Schmidt (johnny-schmidt) commented Aug 19, 2024

Copy link
Copy Markdown
Contributor Author

blegh. if you have an easy way to test - what happens if the top-level schema is type: [string, object]? (we've seen that in the past also)

Edward Gao (@edgao) we would not be able to handle that in avro anyway. What would the top-level string field be called? The field names come from the object properties.

@johnny-schmidt
Johnny Schmidt (johnny-schmidt) force-pushed the issue-6269/destination-s3-respects-nullable-top-level-schema branch from 154e7ff to 77c1f9d Compare August 19, 2024 17:39
@octavia-squidington-iii Octavia Squidington III (octavia-squidington-iii) added the area/documentation Improvements or additions to documentation label Aug 19, 2024
@johnny-schmidt

Johnny Schmidt (johnny-schmidt) commented Aug 19, 2024 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Contributor Author

/publish-java-cdk

🕑 https://github.com/airbytehq/airbyte/actions/runs/10458233305
❌ Publish Java CDK version=0.44.15 failed!

@johnny-schmidt

Johnny Schmidt (johnny-schmidt) commented Aug 19, 2024 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Contributor Author

/publish-java-cdk

🕑 https://github.com/airbytehq/airbyte/actions/runs/10458694678

@johnny-schmidt
Johnny Schmidt (johnny-schmidt) force-pushed the issue-6269/destination-s3-respects-nullable-top-level-schema branch from 9fec536 to 500d2e0 Compare August 19, 2024 18:25
@johnny-schmidt

Johnny Schmidt (johnny-schmidt) commented Aug 19, 2024 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Contributor Author

/publish-java-cdk

🕑 https://github.com/airbytehq/airbyte/actions/runs/10458851761
✅ Successfully published Java CDK version=0.44.15!

@johnny-schmidt

Johnny Schmidt (johnny-schmidt) commented Aug 19, 2024 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Contributor Author

/publish-java-cdk force=true

🕑 https://github.com/airbytehq/airbyte/actions/runs/10462082379

@johnny-schmidt

Johnny Schmidt (johnny-schmidt) commented Aug 19, 2024 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Contributor Author

/publish-java-cdk force=true

🕑 https://github.com/airbytehq/airbyte/actions/runs/10462117821
✅ Successfully published Java CDK version=0.44.15!

@johnny-schmidt
Johnny Schmidt (johnny-schmidt) deleted the issue-6269/destination-s3-respects-nullable-top-level-schema branch August 19, 2024 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
@edgao Edward Gao (edgao) edgao left review comments
@evantahler Evan Tahler (evantahler) evantahler approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area/connectors Connector related issues area/documentation Improvements or additions to documentation CDK Connector Development Kit connectors/destination/s3

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@johnny-schmidt @evantahler @edgao @octavia-squidington-iii