Repository navigation
MSSQL and debezium improvements - #44759
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Octavia Squidington III (octavia-squidington-iii)
added
the
CDK
Octavia Squidington III (octavia-squidington-iii)
added
area/connectors
|
|
||
| if (isEventLogged) { | ||
| val source: JsonNode? = changeEventWithMetadata.eventValueAsJson()["source"] | ||
| val source: JsonNode? = changeEventWithMetadata.eventValueAsJson?.get("source") |
There was a problem hiding this comment.
kotlin doesn't have ?[] unfortunately
Octavia Squidington III (octavia-squidington-iii)
added
the
area/documentation
…entexception-argument-content-is-null-after-adding-primary-key
|
Evan Tahler (@evantahler) I'd like to add a troubleshooting doc for mssql, similarly to what we have in other connectors (e.g). |
|
Rodi Reich Zilberman (@rodireich) - you've got to add the new doc to the sidebar nav as well. I can help if you get stuck! |
…entexception-argument-content-is-null-after-adding-primary-key
Rodi Reich Zilberman (rodireich)
changed the title
…entexception-argument-content-is-null-after-adding-primary-key
Marius Posta (postamar)
left a comment
Marius Posta (postamar)
left a comment
There was a problem hiding this comment.
My only concern here is the potential for log spam, LGTM otherwise.
| event | ||
| .value() | ||
| ?.let { Jsons.deserialize(it) } | ||
| .also { it ?: LOGGER.warn { "Event value is null $event" } } |
There was a problem hiding this comment.
This could spam the logs.
There was a problem hiding this comment.
If we get to the situation where value or key are null then something is seriously misoncifugred, as was the case on the oncall ticket.
I'd rather know what the malformed debezium event looks like. I couldn't figure out the root cause until I was able to get to this information.
…entexception-argument-content-is-null-after-adding-primary-key
|
/publish-java-cdk dry-run=true
|
|
/publish-java-cdk
|
This branch was successfully deployed
4 participants
What
A few issues in debezium and mssql were discovered as a result of https://github.com/airbytehq/oncall/issues/6192 .
op: rwhich is can only be part of an initial snapshot.This PR deals with the discoveries and adds a new troubleshooting page for the root cause of the oncall issue.