Skip to content

[source-postgres] use tcpAlive=true to make JDBC connection more robust upon backpressure - #44878

Merged
Yue Li (theyueli) merged 3 commits into
masterfrom
yue/pg-keepalive
Aug 30, 2024
Merged

Yue Li (theyueli) merged 3 commits into
masterfrom
yue/pg-keepalive

Conversation

@theyueli

@theyueli Yue Li (theyueli) commented Aug 28, 2024 •

Copy link
Copy Markdown
Contributor

What

A possible improvement which will make JDBC connection not get dropped when there is backpressure.

Related to https://github.com/airbytehq/airbyte-internal-issues/issues/7

Solves part of https://github.com/airbytehq/oncall/issues/6315

Can this PR be safely reverted and rolled back?

  • [x ] YES 💚
  • NO ❌

@vercel

vercel Bot commented Aug 28, 2024 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Aug 30, 2024 6:06pm

@evantahler

Copy link
Copy Markdown
Contributor

This is one of the solutions to https://github.com/airbytehq/oncall/issues/6315

@rodireich

Copy link
Copy Markdown
Contributor

Looks good to me (I was under the impression we already had keepalive turned on in the JDBC connection).
You might want to consider, or later consider doing this on the hikari pool config

config.keepaliveTime = ???

@theyueli

Copy link
Copy Markdown
Contributor Author

hikari pool config

Looks good to me (I was under the impression we already had keepalive turned on in the JDBC connection). You might want to consider, or later consider doing this on the hikari pool config

config.keepaliveTime = ???

Rodi Reich Zilberman (@rodireich) great finding!! Do you know what value we shall set? I was overwhelmed by these parameters, there is another one called idle timeout ... is that related?

https://docs.oracle.com/cd/E19159-01/819-3681/abehq/index.html

@theyueli
Yue Li (theyueli) merged commit f502315 into master Aug 30, 2024
@theyueli
Yue Li (theyueli) deleted the yue/pg-keepalive branch August 30, 2024 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/postgres retrospective

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants