destination databricks - update docs for access token connections - #44941
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Evan Tahler (evantahler)
requested review from
Edward Gao (edgao) and
Gireesh Sreepathi (gisripa)
August 30, 2024 21:53
Evan Tahler (evantahler)
marked this pull request as ready for review
August 30, 2024 21:53
Octavia Squidington III (octavia-squidington-iii)
added
the
area/documentation
Evan Tahler (evantahler)
enabled auto-merge (squash)
August 30, 2024 21:53
Octavia Squidington III (octavia-squidington-iii)
added
area/connectors
Edward Gao (edgao)
approved these changes
Aug 30, 2024
Edward Gao (edgao)
left a comment
Edward Gao (edgao)
left a comment
Contributor
There was a problem hiding this comment.
lgtm (your UI looks slightly different from mine, but the instructions are still the same 🤷). It also annoys me that the databricks docs still say "personal access token"...
should we also change the spec.json to say OAuth2 (Recommend for AWS deployments) and Access Token (Recommended for GCP deployments) (i.e. copying the new headers from the docs? (i.e. where it currently just says OAuth2 (Recommended) / Personal Access Token)
Contributor
Author
|
I don't think I have enough confidence yet for the 'recommended' notes in the UI, and I don't know what to say about Azure yet... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
re: https://airbytehq-team.slack.com/archives/C03C4AVJWG4/p1725048018892729