Skip to content

Implemented transient error handling for system errors in MSSQL - #48484

Merged
Yarden Carmeli (yardencarmeli) merged 2 commits into
masterfrom
feature/mssql-system-error-translation
Nov 13, 2024
Merged

Implemented transient error handling for system errors in MSSQL#48484
Yarden Carmeli (yardencarmeli) merged 2 commits into
masterfrom
feature/mssql-system-error-translation

Conversation

@yardencarmeli

@yardencarmeli Yarden Carmeli (yardencarmeli) commented Nov 13, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

What

How

  • Added a Kotlin package (io.airbyte.integrations.source.mssql) to capture MSSql source connector server errors, treat them as transient, and provide an external error message to help our users better understand the issue.
  • Update the MssqlSource file to include the new error handler to be used in our IntegrationRunner.

Review guide

User Impact

  1. Retry mechanism for MSSql source connector system errors.
  2. Better error translation when the MSSql fails on the source side.
  3. No noticeable negative side effects.

Can this PR be safely reverted and rolled back?

  • YES 💚
  • NO ❌

@vercel

vercel Bot commented Nov 13, 2024 •
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 13, 2024 9:36pm

@CLAassistant

CLAassistant commented Nov 13, 2024 •
edited
Loading

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

rodireich
Rodi Reich Zilberman (rodireich) reviewed Nov 13, 2024
View reviewed changes
Comment thread docs/integrations/sources/mssql.md Outdated
| 4.1.6 | 2024-07-30 | [42550](https://github.com/airbytehq/airbyte/pull/42550) | Correctly report stream states. |
| 4.1.5 | 2024-07-29 | [42852](https://github.com/airbytehq/airbyte/pull/42852) | Bump CDK version to latest to use new bug fixes on error translation. |
| 4.1.4 | 2024-07-23 | [42421](https://github.com/airbytehq/airbyte/pull/42421) | Remove final transient error emitter iterators. |
| 4.1.16 | 2024-11-12 | []() | Updating error handler for Mssql (system-error). |

@rodireich Rodi Reich Zilberman (rodireich) Nov 13, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can add now a PR number and push again

@yardencarmeli
Yarden Carmeli (yardencarmeli) deleted the feature/mssql-system-error-translation branch November 13, 2024 23:02

This branch was successfully deployed

1 active deployment
Preview — b72beef9 Deployed Nov 13, 2024 by vercel[bot]
View deployment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rodireich Rodi Reich Zilberman (rodireich) rodireich approved these changes

Assignees

@yardencarmeli Yarden Carmeli (yardencarmeli)

Labels

area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/mssql

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@yardencarmeli @CLAassistant @rodireich @octavia-squidington-iii