🐛 Source Facebook Marketing: Convert values' types according to schema types #4978

Zirochkaa · 2021-07-26T09:46:37Z

Closes #4827.

Pre-merge Checklist

Grant edit access to maintainers (instructions)
Secrets in the connector's spec are annotated with airbyte_secret
Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
Code reviews completed
Documentation updated
- Connector's README.md
- Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
PR name follows PR naming conventions
Connector version bumped like described here

Zirochkaa · 2021-07-26T09:47:07Z

/test connector=source-facebook-marketing

🕑 source-facebook-marketing https://github.com/airbytehq/airbyte/actions/runs/1066944718
❌ source-facebook-marketing https://github.com/airbytehq/airbyte/actions/runs/1066944718

airbyte-integrations/connectors/source-facebook-marketing/integration_tests/test_streams.py

airbyte-integrations/connectors/source-facebook-marketing/acceptance-test-config.yml

keu

see my comments

Zirochkaa · 2021-07-26T13:18:10Z

/test connector=source-facebook-marketing

Zirochkaa · 2021-07-26T14:15:50Z

/test connector=source-facebook-marketing

🕑 source-facebook-marketing https://github.com/airbytehq/airbyte/actions/runs/1067719017
✅ source-facebook-marketing https://github.com/airbytehq/airbyte/actions/runs/1067719017

airbyte-integrations/connectors/source-facebook-marketing/acceptance-test-config.yml

Zirochkaa · 2021-09-07T20:56:50Z

/test connector=source-facebook-marketing

🕑 source-facebook-marketing https://github.com/airbytehq/airbyte/actions/runs/1210966725
✅ source-facebook-marketing https://github.com/airbytehq/airbyte/actions/runs/1210966725

Put back `ads_insights` and `ads_insights_age_and_gender` streams.

Zirochkaa · 2021-09-07T21:41:45Z

/test connector=source-facebook-marketing

🕑 source-facebook-marketing https://github.com/airbytehq/airbyte/actions/runs/1211090402
✅ source-facebook-marketing https://github.com/airbytehq/airbyte/actions/runs/1211090402

Zirochkaa · 2021-09-10T14:17:54Z

/test connector=source-facebook-marketing

🕑 source-facebook-marketing https://github.com/airbytehq/airbyte/actions/runs/1221571321
✅ source-facebook-marketing https://github.com/airbytehq/airbyte/actions/runs/1221571321

sherifnada · 2021-09-13T15:17:00Z

airbyte-integrations/connectors/source-facebook-marketing/source_facebook_marketing/streams.py

+                    if list in self.get_python_type(schema[key]["items"]["type"]):
+                        # TODO Currently we don't have support for list of lists.
+                        pass
+                    elif dict in self.get_python_type(schema[key]["items"]["type"]):


the expression schema[key][items][type] is repeated 3 times, might be good to refactor into a variable for readability e.g: list_items_type = schema[key][items][type]

Nope, we can't do that. schema[key]["items"]["type"] is being used specifically in if statements in which we are sure key items is presented. If I will move schema[key]["items"]["type"] in one place above all if statements then we will keep on getting errors like this one.

airbyte-integrations/connectors/source-facebook-marketing/source_facebook_marketing/streams.py

sherifnada · 2021-09-13T15:19:12Z

airbyte-integrations/connectors/source-facebook-marketing/source_facebook_marketing/streams.py

+        if isinstance(_types, list):
+            return tuple([types_mapping[t] for t in _types if t != "null"])
+
+        return (types_mapping[_types],)


should we return the 0th element in this method instead of from the calling code?

get_python_type() function converts types from schema to python types. This means that we must return values only from types_mapping dictionary.

airbyte-integrations/connectors/source-facebook-marketing/source_facebook_marketing/streams.py

…facebook-marketing-test-fixes

Zirochkaa · 2021-09-14T08:06:32Z

/test connector=source-facebook-marketing

🕑 source-facebook-marketing https://github.com/airbytehq/airbyte/actions/runs/1232787643

Zirochkaa · 2021-09-14T08:09:18Z

/test connector=source-facebook-marketing

🕑 source-facebook-marketing https://github.com/airbytehq/airbyte/actions/runs/1232796545
❌ source-facebook-marketing https://github.com/airbytehq/airbyte/actions/runs/1232796545
🐛 https://gradle.com/s/ehgrblsqtgaoo

Zirochkaa · 2021-09-14T09:28:39Z

/test connector=source-facebook-marketing

🕑 source-facebook-marketing https://github.com/airbytehq/airbyte/actions/runs/1233056672
✅ source-facebook-marketing https://github.com/airbytehq/airbyte/actions/runs/1233056672

…facebook-marketing-test-fixes

Zirochkaa · 2021-09-14T16:35:31Z

/test connector=source-facebook-marketing

🕑 source-facebook-marketing https://github.com/airbytehq/airbyte/actions/runs/1234471393
✅ source-facebook-marketing https://github.com/airbytehq/airbyte/actions/runs/1234471393

Zirochkaa · 2021-09-14T16:44:20Z

/publish connector=connectors/source-facebook-marketing

🕑 connectors/source-facebook-marketing https://github.com/airbytehq/airbyte/actions/runs/1234495096
✅ connectors/source-facebook-marketing https://github.com/airbytehq/airbyte/actions/runs/1234495096

* Update check connection method * #5796 silence printing full config when config validation fails (#5879) * - #5796 silence printing full config when config validation fails * fix unit tests after config validation check changes Co-authored-by: Marcos Eliziario Santos <marcos@coremarcos.com> * Format google-search-console schemas (#6047) * Update ads_insights.json (#5946) fix ads_insights schema according to [facebook docs](https://developers.facebook.com/docs/marketing-api/reference/adgroup/insights/) and my own data * Bump connectors version + update docs (#6060) * 🐛 Source Facebook Marketing: Convert values' types according to schema types (#4978) * Convert values' types according to schema types * Put streams back to `configured_catalog.json` Put back `ads_insights` and `ads_insights_age_and_gender` streams. * Pickup changes from #5946 * Implement change request + fix previous PR * Update schema * Remove items_type from convert_to_schema_types() * Bump connectors version * add oauth to connector_base dependencies (#6064) * use spec when persisting source configs (#6036) * switch most usages of writing sources to using specs * fix other usages * fix test * only wait on the server in the scheduler, not the worker * fix * rephrase sanity check and remove stdout * 🎉 Source Stripe: Add `PaymentIntents` stream (#6004) * Add `PaymentIntents` stream * Update docs * Implement change request + few updates Split `source.py` file into `source.py` and `streams.py` files. Update `payment_intents.json` file. * Bump connectors version + update docs * Add skeleton for databricks destination (#5629) Co-authored-by: Liren Tu <tuliren.git@outlook.com> Co-authored-by: LiRen Tu <tuliren@gmail.com> * Revert "Add skeleton for databricks destination (#5629)" (#6066) This reverts commit 79256c4. * 🎉 New Destination: Databricks (#5998) Implement new destination connector for databricks delta lake. Resolves #2075. Co-authored-by: George Claireaux <george@claireaux.co.uk> Co-authored-by: Sherif A. Nada <snadalive@gmail.com> * Source PostHog: add support for self-hosted instances (#6058) * publish #6058 (#6059) * Destination Kafka: correct spec json and data types in config (#6040) * correct spec json and data types in config * bump version * correct tests * correct config parser NPE * format files Co-authored-by: Marcos Marx <marcosmarx@MacBook-Pro-de-Marcos.local> * Fix or delete broken links (#6069) * Fix more doc issues (#6072) * 🎉 Added optional platform flag for build image script (#6000) * Fix dependabot security alert. (#6073) * Pin set value to greater than 4.0.1 to fix security warning. * Format the rest of the connectors. * add coverage report (#6045) Co-authored-by: Dmytro Rezchykov <dmitry.rezchykov@zazmic.com> * Fix the format of the data returned by Google Ads oauth to match the config accepted by the connector (#6032) * update salesforce docs (#6081) * 🎉 Source Github: add caching for all streams (#5949) * Source Github: add checking for all streams * bump version, update changelogs * Disable automatic migration acceptance test (#5988) - The automatic migration acceptance test no longer works because of the new Flyway migration system. - The file-based migration system is being deprecated. * 🎉 CDK: Add requests native authenticator support (#5731) * Add requests native auth class * Update init file. Update type annotations. Bump version. * Update TokenAuthenticator implementation. Update Oauth2Authenticator implemetation. Add CHANGELOG.md record. * Update Oauth2Authenticator default value setting. Update CHANGELOG.md * Add requests native authenticator tests * Add CDK requests native __call__ method tests. Update CHANGELOG.md * Add outdated auth deprication messages * Update requests native auth __call__ method tests * Bump CDK version to 0.1.20 * Interface changes to support separating secrets from the config (#6065) * Interface changes to support separating secrets from the config * Cleanup from PR comments and whitespace * Update log message for empty env variable (#6115) Co-authored-by: Jared Rhizor <jared@dataline.io> * Bump Airbyte version from 0.29.17-alpha to 0.29.18-alpha (#6125) Co-authored-by: davinchia <davinchia@users.noreply.github.com> * return auth spec in the API when getting definition specification (#6121) * Ignore python test coverage files (#6144) * CDK: support nested refs resolving (#6044) Co-authored-by: Dmytro Rezchykov <dmitry.rezchykov@zazmic.com> * feat: path for nested fields (#6130) * feat: path for nested fields * fix: clipRule error * fix: remove field name * Fix request middleware for ConnectionService (#6148) * Jamakase/update onboarding flow (#5656) * Doc explains normalization full-refresh implications (#6097) * update docs * add info in quickstart connection page * update abhi comments Co-authored-by: Marcos Marx <marcosmarx@MacBook-Pro-de-Marcos.local> * Fix migration validation issue (#6154) Resolves #6151. * Bump Airbyte version from 0.29.18-alpha to 0.29.19-alpha (#6156) Co-authored-by: tuliren <tuliren@users.noreply.github.com> * Add information on which destinations support Incremental - Deduped History in their docs (#6031) Co-authored-by: Abhi Vaidyanatha <abhivaidyanatha@Abhis-MacBook-Pro.local> * Update Airbyte Spec acknowledgements. (#6155) Co-authored-by: Abhi Vaidyanatha <abhivaidyanatha@Abhis-MacBook-Pro.local> * Update new integration request * Add back the migration acceptance test (#6163) * 🎉 Create a Helm Chart For Airbyte (#5891) See number #1868. This creates an initial helm chart for installing Airbyte in Kubernetes to make it easier for users who are more familiar with helm. It also includes GitHub actions to help continually test that the chart works in the most basic case. All of the templates are based off of the kustomize folder, but minio and postgres have been removed in favor of adding the bitnami helm charts as dependencies since they have an active community and allow easily tweaking their install. * Fix OAuth Summary strings (#6143) Co-authored-by: Marcos Eliziario Santos <eliziario@users.noreply.github.com> Co-authored-by: Marcos Eliziario Santos <marcos@coremarcos.com> Co-authored-by: oleh.zorenko <19872253+Zirochkaa@users.noreply.github.com> Co-authored-by: Mauro <35332423+m-ronchi@users.noreply.github.com> Co-authored-by: Sherif A. Nada <snadalive@gmail.com> Co-authored-by: Jared Rhizor <jared@dataline.io> Co-authored-by: George Claireaux <george@claireaux.co.uk> Co-authored-by: Liren Tu <tuliren.git@outlook.com> Co-authored-by: LiRen Tu <tuliren@gmail.com> Co-authored-by: coeurdestenebres <90490546+coeurdestenebres@users.noreply.github.com> Co-authored-by: Marcos Marx <marcosmarxm@users.noreply.github.com> Co-authored-by: Marcos Marx <marcosmarx@MacBook-Pro-de-Marcos.local> Co-authored-by: Harsha Teja Kanna <h7kanna@users.noreply.github.com> Co-authored-by: Davin Chia <davinchia@gmail.com> Co-authored-by: Dmytro <avida.d3@gmail.com> Co-authored-by: Dmytro Rezchykov <dmitry.rezchykov@zazmic.com> Co-authored-by: Yevhenii <34103125+yevhenii-ldv@users.noreply.github.com> Co-authored-by: Jenny Brown <85510829+airbyte-jenny@users.noreply.github.com> Co-authored-by: davinchia <davinchia@users.noreply.github.com> Co-authored-by: Iakov Salikov <36078770+isalikov@users.noreply.github.com> Co-authored-by: Artem Astapenko <3767150+Jamakase@users.noreply.github.com> Co-authored-by: tuliren <tuliren@users.noreply.github.com> Co-authored-by: Abhi Vaidyanatha <abhi@airbyte.io> Co-authored-by: Abhi Vaidyanatha <abhivaidyanatha@Abhis-MacBook-Pro.local> Co-authored-by: Jonathan Stacks <jonstacks@users.noreply.github.com> Co-authored-by: Christophe Duong <christophe.duong@gmail.com>

* Add GET_FBA_INVENTORY_AGED_DATA data * Add GET_MERCHANT_LISTINGS_ALL_DATA stream support * Update schemas * Update configured_catalog.json * Update connector to airbyte-cdk * Add amazon seller partner test creds * Update state sample files * Apply code format * Update acceptance-test-config.yml * Add dummy integration test * Refactor auth signature. Update streams.py * Remove print_function import from auth.py * Refactor source class. Add pydantic spec. PR fixes. * Add dummy integration test * Typing added. Add _create_prepared_request docstring. * Add extra streams and schemas * Update docs and spec * Post merge code fixes * Fix test setup * Fix test setup * Add sample_state.json * Update reports streams logics. Update test and config files. * Update tests config. Small code style fixes. * Add reports stream slices. Update check_connection method. * Post review fixes. * Streams update * Add reports document retrieval and decrypting. Update schemas and configs. * Add CVS parsing into result rows * Update ReportsAmazonSPStream class to be the child of Stream class. Update GET_FLAT_FILE_OPEN_LISTINGS_DATA and GET_MERCHANT_LISTINGS_ALL_DATA schemas. * Schema updates * Source check method updated * Update ReportsAmazonSPStream retry report logics * Update check_connection source method * Update reports read_records method. Update report schemas. * Update streams.py * Update acceptance tests config. Add small code fixes. * Update report read_records logics * Add reports streams rate limit handling logics. Add rate limit unit tests. * Source Amazon SP: Update reports streams logics. (#5311) * Update check connection method * #5796 silence printing full config when config validation fails (#5879) * - #5796 silence printing full config when config validation fails * fix unit tests after config validation check changes Co-authored-by: Marcos Eliziario Santos <marcos@coremarcos.com> * Format google-search-console schemas (#6047) * Update ads_insights.json (#5946) fix ads_insights schema according to [facebook docs](https://developers.facebook.com/docs/marketing-api/reference/adgroup/insights/) and my own data * Bump connectors version + update docs (#6060) * 🐛 Source Facebook Marketing: Convert values' types according to schema types (#4978) * Convert values' types according to schema types * Put streams back to `configured_catalog.json` Put back `ads_insights` and `ads_insights_age_and_gender` streams. * Pickup changes from #5946 * Implement change request + fix previous PR * Update schema * Remove items_type from convert_to_schema_types() * Bump connectors version * add oauth to connector_base dependencies (#6064) * use spec when persisting source configs (#6036) * switch most usages of writing sources to using specs * fix other usages * fix test * only wait on the server in the scheduler, not the worker * fix * rephrase sanity check and remove stdout * 🎉 Source Stripe: Add `PaymentIntents` stream (#6004) * Add `PaymentIntents` stream * Update docs * Implement change request + few updates Split `source.py` file into `source.py` and `streams.py` files. Update `payment_intents.json` file. * Bump connectors version + update docs * Add skeleton for databricks destination (#5629) Co-authored-by: Liren Tu <tuliren.git@outlook.com> Co-authored-by: LiRen Tu <tuliren@gmail.com> * Revert "Add skeleton for databricks destination (#5629)" (#6066) This reverts commit 79256c4. * 🎉 New Destination: Databricks (#5998) Implement new destination connector for databricks delta lake. Resolves #2075. Co-authored-by: George Claireaux <george@claireaux.co.uk> Co-authored-by: Sherif A. Nada <snadalive@gmail.com> * Source PostHog: add support for self-hosted instances (#6058) * publish #6058 (#6059) * Destination Kafka: correct spec json and data types in config (#6040) * correct spec json and data types in config * bump version * correct tests * correct config parser NPE * format files Co-authored-by: Marcos Marx <marcosmarx@MacBook-Pro-de-Marcos.local> * Fix or delete broken links (#6069) * Fix more doc issues (#6072) * 🎉 Added optional platform flag for build image script (#6000) * Fix dependabot security alert. (#6073) * Pin set value to greater than 4.0.1 to fix security warning. * Format the rest of the connectors. * add coverage report (#6045) Co-authored-by: Dmytro Rezchykov <dmitry.rezchykov@zazmic.com> * Fix the format of the data returned by Google Ads oauth to match the config accepted by the connector (#6032) * update salesforce docs (#6081) * 🎉 Source Github: add caching for all streams (#5949) * Source Github: add checking for all streams * bump version, update changelogs * Disable automatic migration acceptance test (#5988) - The automatic migration acceptance test no longer works because of the new Flyway migration system. - The file-based migration system is being deprecated. * 🎉 CDK: Add requests native authenticator support (#5731) * Add requests native auth class * Update init file. Update type annotations. Bump version. * Update TokenAuthenticator implementation. Update Oauth2Authenticator implemetation. Add CHANGELOG.md record. * Update Oauth2Authenticator default value setting. Update CHANGELOG.md * Add requests native authenticator tests * Add CDK requests native __call__ method tests. Update CHANGELOG.md * Add outdated auth deprication messages * Update requests native auth __call__ method tests * Bump CDK version to 0.1.20 * Interface changes to support separating secrets from the config (#6065) * Interface changes to support separating secrets from the config * Cleanup from PR comments and whitespace * Update log message for empty env variable (#6115) Co-authored-by: Jared Rhizor <jared@dataline.io> * Bump Airbyte version from 0.29.17-alpha to 0.29.18-alpha (#6125) Co-authored-by: davinchia <davinchia@users.noreply.github.com> * return auth spec in the API when getting definition specification (#6121) * Ignore python test coverage files (#6144) * CDK: support nested refs resolving (#6044) Co-authored-by: Dmytro Rezchykov <dmitry.rezchykov@zazmic.com> * feat: path for nested fields (#6130) * feat: path for nested fields * fix: clipRule error * fix: remove field name * Fix request middleware for ConnectionService (#6148) * Jamakase/update onboarding flow (#5656) * Doc explains normalization full-refresh implications (#6097) * update docs * add info in quickstart connection page * update abhi comments Co-authored-by: Marcos Marx <marcosmarx@MacBook-Pro-de-Marcos.local> * Fix migration validation issue (#6154) Resolves #6151. * Bump Airbyte version from 0.29.18-alpha to 0.29.19-alpha (#6156) Co-authored-by: tuliren <tuliren@users.noreply.github.com> * Add information on which destinations support Incremental - Deduped History in their docs (#6031) Co-authored-by: Abhi Vaidyanatha <abhivaidyanatha@Abhis-MacBook-Pro.local> * Update Airbyte Spec acknowledgements. (#6155) Co-authored-by: Abhi Vaidyanatha <abhivaidyanatha@Abhis-MacBook-Pro.local> * Update new integration request * Add back the migration acceptance test (#6163) * 🎉 Create a Helm Chart For Airbyte (#5891) See number #1868. This creates an initial helm chart for installing Airbyte in Kubernetes to make it easier for users who are more familiar with helm. It also includes GitHub actions to help continually test that the chart works in the most basic case. All of the templates are based off of the kustomize folder, but minio and postgres have been removed in favor of adding the bitnami helm charts as dependencies since they have an active community and allow easily tweaking their install. * Fix OAuth Summary strings (#6143) Co-authored-by: Marcos Eliziario Santos <eliziario@users.noreply.github.com> Co-authored-by: Marcos Eliziario Santos <marcos@coremarcos.com> Co-authored-by: oleh.zorenko <19872253+Zirochkaa@users.noreply.github.com> Co-authored-by: Mauro <35332423+m-ronchi@users.noreply.github.com> Co-authored-by: Sherif A. Nada <snadalive@gmail.com> Co-authored-by: Jared Rhizor <jared@dataline.io> Co-authored-by: George Claireaux <george@claireaux.co.uk> Co-authored-by: Liren Tu <tuliren.git@outlook.com> Co-authored-by: LiRen Tu <tuliren@gmail.com> Co-authored-by: coeurdestenebres <90490546+coeurdestenebres@users.noreply.github.com> Co-authored-by: Marcos Marx <marcosmarxm@users.noreply.github.com> Co-authored-by: Marcos Marx <marcosmarx@MacBook-Pro-de-Marcos.local> Co-authored-by: Harsha Teja Kanna <h7kanna@users.noreply.github.com> Co-authored-by: Davin Chia <davinchia@gmail.com> Co-authored-by: Dmytro <avida.d3@gmail.com> Co-authored-by: Dmytro Rezchykov <dmitry.rezchykov@zazmic.com> Co-authored-by: Yevhenii <34103125+yevhenii-ldv@users.noreply.github.com> Co-authored-by: Jenny Brown <85510829+airbyte-jenny@users.noreply.github.com> Co-authored-by: davinchia <davinchia@users.noreply.github.com> Co-authored-by: Iakov Salikov <36078770+isalikov@users.noreply.github.com> Co-authored-by: Artem Astapenko <3767150+Jamakase@users.noreply.github.com> Co-authored-by: tuliren <tuliren@users.noreply.github.com> Co-authored-by: Abhi Vaidyanatha <abhi@airbyte.io> Co-authored-by: Abhi Vaidyanatha <abhivaidyanatha@Abhis-MacBook-Pro.local> Co-authored-by: Jonathan Stacks <jonstacks@users.noreply.github.com> Co-authored-by: Christophe Duong <christophe.duong@gmail.com> * Bump source version. Update source docs. * Mock time.sleep in test_reports_stream_send_request_backoff_exception test * Acceptance test basic_read test disabled Co-authored-by: Marcos Eliziario Santos <eliziario@users.noreply.github.com> Co-authored-by: Marcos Eliziario Santos <marcos@coremarcos.com> Co-authored-by: oleh.zorenko <19872253+Zirochkaa@users.noreply.github.com> Co-authored-by: Mauro <35332423+m-ronchi@users.noreply.github.com> Co-authored-by: Sherif A. Nada <snadalive@gmail.com> Co-authored-by: Jared Rhizor <jared@dataline.io> Co-authored-by: George Claireaux <george@claireaux.co.uk> Co-authored-by: Liren Tu <tuliren.git@outlook.com> Co-authored-by: LiRen Tu <tuliren@gmail.com> Co-authored-by: coeurdestenebres <90490546+coeurdestenebres@users.noreply.github.com> Co-authored-by: Marcos Marx <marcosmarxm@users.noreply.github.com> Co-authored-by: Marcos Marx <marcosmarx@MacBook-Pro-de-Marcos.local> Co-authored-by: Harsha Teja Kanna <h7kanna@users.noreply.github.com> Co-authored-by: Davin Chia <davinchia@gmail.com> Co-authored-by: Dmytro <avida.d3@gmail.com> Co-authored-by: Dmytro Rezchykov <dmitry.rezchykov@zazmic.com> Co-authored-by: Yevhenii <34103125+yevhenii-ldv@users.noreply.github.com> Co-authored-by: Jenny Brown <85510829+airbyte-jenny@users.noreply.github.com> Co-authored-by: davinchia <davinchia@users.noreply.github.com> Co-authored-by: Iakov Salikov <36078770+isalikov@users.noreply.github.com> Co-authored-by: Artem Astapenko <3767150+Jamakase@users.noreply.github.com> Co-authored-by: tuliren <tuliren@users.noreply.github.com> Co-authored-by: Abhi Vaidyanatha <abhi@airbyte.io> Co-authored-by: Abhi Vaidyanatha <abhivaidyanatha@Abhis-MacBook-Pro.local> Co-authored-by: Jonathan Stacks <jonstacks@users.noreply.github.com> Co-authored-by: Christophe Duong <christophe.duong@gmail.com>

Zirochkaa self-assigned this Jul 26, 2021

github-actions bot added the area/connectors Connector related issues label Jul 26, 2021

Zirochkaa linked an issue Jul 26, 2021 that may be closed by this pull request

Source Facebook Marketing: SAT fails on schema validation #4827

Closed

Zirochkaa mentioned this pull request Jul 26, 2021

Source Facebook Marketing: SAT fails on schema validation #4827

Closed

keu reviewed Jul 26, 2021

View reviewed changes

airbyte-integrations/connectors/source-facebook-marketing/integration_tests/test_streams.py Outdated Show resolved Hide resolved

keu reviewed Jul 26, 2021

View reviewed changes

airbyte-integrations/connectors/source-facebook-marketing/acceptance-test-config.yml Outdated Show resolved Hide resolved

keu reviewed Jul 26, 2021

View reviewed changes

Zirochkaa changed the title ~~4827 Facebook Marketing test fixes~~ Source Facebook Marketing: test fixes Jul 26, 2021

Zirochkaa requested a review from keu July 26, 2021 15:24

sherifnada approved these changes Jul 26, 2021

View reviewed changes

airbyte-integrations/connectors/source-facebook-marketing/acceptance-test-config.yml Outdated Show resolved Hide resolved

Zirochkaa force-pushed the oleh/4827-facebook-marketing-test-fixes branch from 0362768 to 1cb1618 Compare August 20, 2021 07:37

Zirochkaa force-pushed the oleh/4827-facebook-marketing-test-fixes branch from 1cb1618 to a405fe1 Compare August 30, 2021 13:15

Zirochkaa changed the title ~~Source Facebook Marketing: test fixes~~ 🐛 Source Facebook Marketing: Convert values' types according to schema types Sep 7, 2021

Convert values' types according to schema types

f926982

Zirochkaa force-pushed the oleh/4827-facebook-marketing-test-fixes branch from a405fe1 to f926982 Compare September 7, 2021 20:56

github-actions bot added the area/documentation Improvements or additions to documentation label Sep 7, 2021

Zirochkaa removed the request for review from keu September 7, 2021 20:57

jrhizor temporarily deployed to more-secrets September 7, 2021 20:59 Inactive

Zirochkaa requested review from yevhenii-ldv, avida and htrueman September 7, 2021 21:04

Put streams back to configured_catalog.json

1d7d331

Put back `ads_insights` and `ads_insights_age_and_gender` streams.

jrhizor temporarily deployed to more-secrets September 7, 2021 21:44 Inactive

Zirochkaa requested a review from sherifnada September 9, 2021 06:41

avida approved these changes Sep 9, 2021

View reviewed changes

htrueman approved these changes Sep 9, 2021

View reviewed changes

Pickup changes from #5946

436f7ea

jrhizor temporarily deployed to more-secrets September 10, 2021 14:20 Inactive

sherifnada approved these changes Sep 13, 2021

View reviewed changes

Zirochkaa added 2 commits September 14, 2021 10:09

Merge branch 'master' of github.com:airbytehq/airbyte into oleh/4827-…

e235bf1

…facebook-marketing-test-fixes

Implement change request + fix previous PR

1b54589

Zirochkaa requested a review from sherifnada September 14, 2021 08:06

Update schema

c0dbf49

jrhizor temporarily deployed to more-secrets September 14, 2021 08:11 Inactive

Remove items_type from convert_to_schema_types()

65690aa

jrhizor temporarily deployed to more-secrets September 14, 2021 09:31 Inactive

sherifnada approved these changes Sep 14, 2021

View reviewed changes

Zirochkaa added 2 commits September 14, 2021 19:33

Merge branch 'master' of github.com:airbytehq/airbyte into oleh/4827-…

e123327

…facebook-marketing-test-fixes

Bump connectors version

12ea2d2

jrhizor temporarily deployed to more-secrets September 14, 2021 16:38 Inactive

jrhizor temporarily deployed to more-secrets September 14, 2021 16:46 Inactive

Zirochkaa merged commit 6d39afc into master Sep 14, 2021

Zirochkaa deleted the oleh/4827-facebook-marketing-test-fixes branch September 14, 2021 18:21

jrhizor mentioned this pull request Sep 16, 2021

Bump Airbyte version from 0.29.17-alpha to 0.29.18-alpha #6125

Merged

karinakuz added connectors/sources-api connectors/source/facebook-marketing labels Jan 5, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

🐛 Source Facebook Marketing: Convert values' types according to schema types #4978

🐛 Source Facebook Marketing: Convert values' types according to schema types #4978

Zirochkaa commented Jul 26, 2021 •

edited

Zirochkaa commented Jul 26, 2021 •

edited by github-actions bot

keu left a comment

Zirochkaa commented Jul 26, 2021

Zirochkaa commented Jul 26, 2021 •

edited by github-actions bot

Zirochkaa commented Sep 7, 2021 •

edited by github-actions bot

Zirochkaa commented Sep 7, 2021 •

edited by github-actions bot

Zirochkaa commented Sep 10, 2021 •

edited by github-actions bot

sherifnada Sep 13, 2021

Zirochkaa Sep 14, 2021

Zirochkaa Sep 14, 2021

sherifnada Sep 13, 2021

Zirochkaa Sep 14, 2021

Zirochkaa commented Sep 14, 2021 •

edited by github-actions bot

Zirochkaa commented Sep 14, 2021 •

edited by github-actions bot

Zirochkaa commented Sep 14, 2021 •

edited by github-actions bot

Zirochkaa commented Sep 14, 2021 •

edited by github-actions bot

Zirochkaa commented Sep 14, 2021 •

edited by github-actions bot

🐛 Source Facebook Marketing: Convert values' types according to schema types #4978

🐛 Source Facebook Marketing: Convert values' types according to schema types #4978

Conversation

Zirochkaa commented Jul 26, 2021 • edited

Pre-merge Checklist

Zirochkaa commented Jul 26, 2021 • edited by github-actions bot

keu left a comment

Choose a reason for hiding this comment

Zirochkaa commented Jul 26, 2021

Zirochkaa commented Jul 26, 2021 • edited by github-actions bot

Zirochkaa commented Sep 7, 2021 • edited by github-actions bot

Zirochkaa commented Sep 7, 2021 • edited by github-actions bot

Zirochkaa commented Sep 10, 2021 • edited by github-actions bot

sherifnada Sep 13, 2021

Choose a reason for hiding this comment

Zirochkaa Sep 14, 2021

Choose a reason for hiding this comment

Zirochkaa Sep 14, 2021

Choose a reason for hiding this comment

sherifnada Sep 13, 2021

Choose a reason for hiding this comment

Zirochkaa Sep 14, 2021

Choose a reason for hiding this comment

Zirochkaa commented Sep 14, 2021 • edited by github-actions bot

Zirochkaa commented Sep 14, 2021 • edited by github-actions bot

Zirochkaa commented Sep 14, 2021 • edited by github-actions bot

Zirochkaa commented Sep 14, 2021 • edited by github-actions bot

Zirochkaa commented Sep 14, 2021 • edited by github-actions bot

Zirochkaa commented Jul 26, 2021 •

edited

Zirochkaa commented Jul 26, 2021 •

edited by github-actions bot

Zirochkaa commented Jul 26, 2021 •

edited by github-actions bot

Zirochkaa commented Sep 7, 2021 •

edited by github-actions bot

Zirochkaa commented Sep 7, 2021 •

edited by github-actions bot

Zirochkaa commented Sep 10, 2021 •

edited by github-actions bot

Zirochkaa commented Sep 14, 2021 •

edited by github-actions bot

Zirochkaa commented Sep 14, 2021 •

edited by github-actions bot

Zirochkaa commented Sep 14, 2021 •

edited by github-actions bot

Zirochkaa commented Sep 14, 2021 •

edited by github-actions bot

Zirochkaa commented Sep 14, 2021 •

edited by github-actions bot