destination-snowflake: Use airbyte/java-connector-base:1.0.0 - #49913
Merged
Augustin (alafanechere) merged 4 commits intoJan 9, 2025
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Augustin (alafanechere)
force-pushed
the
destination-snowflake/base-image-migration
branch
from
December 18, 2024 14:58
6cd7eed to
8f40776
Compare
Contributor
Author
|
/format-fix
|
Octavia Squidington III (octavia-squidington-iii)
added
area/connectors
Augustin (alafanechere)
enabled auto-merge (squash)
December 19, 2024 08:12
Augustin (alafanechere)
disabled auto-merge
December 19, 2024 11:08
Contributor
There was a problem hiding this comment.
Augustin (@alafanechere) why is this file changing so much if the main changeset is the base image?
Contributor
Author
There was a problem hiding this comment.
It's because the addition of the base image address was automated and serializing the metadata file back to yaml changed the original order. Nothing is really changing except the connectorBuildOptions. It's indeed tricky to review and trust. I'll make the change manually for certified connectors.
Davin Chia (davinchia)
approved these changes
Jan 8, 2025
Augustin (alafanechere)
deleted the
destination-snowflake/base-image-migration
branch
January 9, 2025 15:18
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make the connector use our official base image for java connectors