Skip to content

source-mysql: simplify MySqlSelectQuerier - #49948

Merged
Marius Posta (postamar) merged 6 commits into
masterfrom
postamar/source-mysql-simplify-select-querier
Dec 20, 2024
Merged

Marius Posta (postamar) merged 6 commits into
masterfrom
postamar/source-mysql-simplify-select-querier

Conversation

@postamar

@postamar Marius Posta (postamar) commented Dec 19, 2024 •

Copy link
Copy Markdown
Contributor

What

This PR is based on #49949 and uses the changes introduced therein to make the MySqlSelectQuerier in source-mysql a lot simpler.

This PR tracks the CDK version 231 which includes changes from #49949 #49920 #49132 #49923.

This PR flips the release candidate flag for progressive rollouts for source-mysql

How

statementFetchSize is set to Integer.MIN_VALUE and resultSetFetchSize is set to the original fetchSize.

Review guide

Understand #49949 then look at this

User Impact

None

Can this PR be safely reverted and rolled back?

  • YES 💚
  • NO ❌

@postamar
Marius Posta (postamar) requested a review from a team as a code owner December 19, 2024 20:27
@vercel

vercel Bot commented Dec 19, 2024 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 20, 2024 2:09pm

Base automatically changed from postamar/source-mysql-normalized-names to master December 19, 2024 20:44
@postamar
Marius Posta (postamar) force-pushed the postamar/source-mysql-simplify-select-querier branch from 7b32558 to 31ee199 Compare December 19, 2024 20:49
@postamar Marius Posta (postamar) changed the title bulk-cdk-toolkits-extract-jdbc,source-mysql: simplify MySqlSelectQuerier source-mysql: simplify MySqlSelectQuerier Dec 19, 2024
@postamar
Marius Posta (postamar) marked this pull request as draft December 19, 2024 20:51
@postamar
Marius Posta (postamar) changed the base branch from master to postamar/bulk-cdk-select-querier-parameters December 19, 2024 20:52
@postamar
Marius Posta (postamar) force-pushed the postamar/bulk-cdk-select-querier-parameters branch from 42c1043 to 16595f1 Compare December 19, 2024 21:26
@postamar
Marius Posta (postamar) force-pushed the postamar/source-mysql-simplify-select-querier branch from 31ee199 to 3120a42 Compare December 19, 2024 21:27
@octavia-squidington-iii Octavia Squidington III (octavia-squidington-iii) removed the CDK Connector Development Kit label Dec 19, 2024
@postamar
Marius Posta (postamar) marked this pull request as ready for review December 19, 2024 21:46
Base automatically changed from postamar/bulk-cdk-select-querier-parameters to master December 20, 2024 13:24
@octavia-squidington-iii Octavia Squidington III (octavia-squidington-iii) added the area/documentation Improvements or additions to documentation label Dec 20, 2024
@postamar
Marius Posta (postamar) merged commit 2910475 into master Dec 20, 2024
@postamar
Marius Posta (postamar) deleted the postamar/source-mysql-simplify-select-querier branch December 20, 2024 14:24

This branch was successfully deployed

1 active deployment
Preview — f970304d Deployed Dec 20, 2024 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/connectors Connector related issues area/documentation Improvements or additions to documentation CDK Connector Development Kit connectors/source/mysql

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants