Repository navigation
source-mysql: simplify MySqlSelectQuerier - #49948
Merged
Marius Posta (postamar) merged 6 commits intoDec 20, 2024
Merged
Marius Posta (postamar) merged 6 commits into
Marius Posta (postamar) merged 6 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Base automatically changed from
postamar/source-mysql-normalized-names
to
master
December 19, 2024 20:44
Marius Posta (postamar)
force-pushed
the
postamar/source-mysql-simplify-select-querier
branch
from
December 19, 2024 20:49
7b32558 to
31ee199
Compare
Marius Posta (postamar)
marked this pull request as draft
December 19, 2024 20:51
1 of 2 tasks
Marius Posta (postamar)
changed the base branch from
master
to
postamar/bulk-cdk-select-querier-parameters
December 19, 2024 20:52
Marius Posta (postamar)
force-pushed
the
postamar/bulk-cdk-select-querier-parameters
branch
from
December 19, 2024 21:26
42c1043 to
16595f1
Compare
Marius Posta (postamar)
force-pushed
the
postamar/source-mysql-simplify-select-querier
branch
from
December 19, 2024 21:27
31ee199 to
3120a42
Compare
Marius Posta (postamar)
marked this pull request as ready for review
December 19, 2024 21:46
Marius Posta (postamar)
force-pushed
the
postamar/source-mysql-simplify-select-querier
branch
from
December 19, 2024 22:09
3120a42 to
b9ee47a
Compare
Stephane Geneix (stephane-airbyte)
approved these changes
Dec 20, 2024
Base automatically changed from
postamar/bulk-cdk-select-querier-parameters
to
master
December 20, 2024 13:24
Marius Posta (postamar)
deleted the
postamar/source-mysql-simplify-select-querier
branch
December 20, 2024 14:24
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
This PR is based on #49949 and uses the changes introduced therein to make the
MySqlSelectQuerierin source-mysql a lot simpler.This PR tracks the CDK version 231 which includes changes from #49949 #49920 #49132 #49923.
This PR flips the release candidate flag for progressive rollouts for source-mysql
How
statementFetchSizeis set toInteger.MIN_VALUEandresultSetFetchSizeis set to the originalfetchSize.Review guide
Understand #49949 then look at this
User Impact
None
Can this PR be safely reverted and rolled back?