feat: implement schema comparison logic - #50400
Merged
Merged
Conversation
Subodh Chaturvedi (subodh1810)
requested a review
from a team
as a code owner
December 23, 2024 15:25
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Octavia Squidington III (octavia-squidington-iii)
added
area/connectors
Contributor
Author
|
/format-fix
|
Subodh Chaturvedi (subodh1810)
requested review from
Edward Gao (edgao) and
Francis Genet (frifriSF59)
December 24, 2024 10:05
Francis Genet (frifriSF59)
approved these changes
Dec 24, 2024
| * required -> optional. | ||
| */ | ||
| data class ColumnDiff( | ||
| val newColumns: MutableList<String> = mutableListOf(), |
Contributor
There was a problem hiding this comment.
how hard would it be to track List<List<String>> instead of encoding the path into a string? then we don't need to do the substring stuff in splitIntoParentAndLeaf. Which also makes us more resilient to people putting literal ~ into their field names
Francis Genet (frifriSF59)
force-pushed
the
iceberg-schema-comparator
branch
2 times, most recently
from
January 8, 2025 23:45
bff174d to
9ca132e
Compare
# Conflicts: # airbyte-integrations/connectors/destination-s3-data-lake/src/main/kotlin/io/airbyte/integrations/destination/iceberg/v2/IcebergTypesComparator.kt # airbyte-integrations/connectors/destination-s3-data-lake/src/test/kotlin/io/airbyte/integrations/destination/iceberg/v2/IcebergTypesComparatorTest.kt # Conflicts: # airbyte-integrations/connectors/destination-s3-data-lake/src/main/kotlin/io/airbyte/integrations/destination/s3_data_lake/IcebergTypesComparator.kt # airbyte-integrations/connectors/destination-s3-data-lake/src/test/kotlin/io/airbyte/integrations/destination/s3_data_lake/IcebergTypesComparatorTest.kt
Francis Genet (frifriSF59)
force-pushed
the
iceberg-schema-comparator
branch
from
January 9, 2025 22:15
b94f5f7 to
6cb11f4
Compare
Octavia Squidington III (octavia-squidington-iii)
added
the
area/documentation
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of https://github.com/airbytehq/airbyte-internal-issues/issues/10918