Repository navigation
Destination S3 Data Lake: avoid System.setProperty in assume role mode - #50971
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Octavia Squidington III (octavia-squidington-iii)
added
area/connectors
Edward Gao (edgao)
force-pushed
the
edgao/derp
branch
from
January 9, 2025 19:42
37656d1 to
110e3d6
Compare
Octavia Squidington III (octavia-squidington-iii)
added
connectors/destination/s3-data-lake
and removed
CDK
Edward Gao (edgao)
changed the title
Contributor
Author
|
fyi I pushed 3cd2c47, which seems to work? It kills the it works locally on the tests I spot-checked 🤷 (cc Subodh Chaturvedi (@subodh1810) since you ran into the problem originally - is there some other problem I'm missing?) |
Edward Gao (edgao)
marked this pull request as ready for review
January 9, 2025 21:26
| AwsProperties.CLIENT_ASSUME_ROLE_EXTERNAL_ID to externalId, | ||
| AwsClientProperties.CLIENT_CREDENTIALS_PROVIDER to | ||
| GlueCredentialsProvider::class.java.name, | ||
| "${AwsClientProperties.CLIENT_CREDENTIALS_PROVIDER}.$AWS_CREDENTIALS_MODE" to |
Contributor
There was a problem hiding this comment.
The fact that this is the expected way of handling those scenarios is blowing my mind.
Octavia Squidington III (octavia-squidington-iii)
added
the
area/documentation
Francis Genet (frifriSF59)
approved these changes
Jan 9, 2025
Edward Gao (edgao)
enabled auto-merge (squash)
January 10, 2025 16:26
Octavia Squidington III (octavia-squidington-iii)
added
the
CDK
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DefaultS3FileIOAwsClientFactorycallss3FileIOProperties.applyCredentialConfigurations, which callsawsClientProperties.credentialsProvider, which prioritizes the accessKey property over AwsClientProperties.CLIENT_CREDENTIALS_PROVIDER.so stop setting that property entirely in assume role mode. Also make our creds provider a bit better.
(also, kill the region system property, which means we're now doing everything via the iceberg props 🎉 )