Repository navigation
[S3-data-lake] Remove/Rename all occurences of iceberg.v2 - #51012
Merged
Francis Genet (frifriSF59) merged 9 commits intoJan 9, 2025
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Octavia Squidington III (octavia-squidington-iii)
added
area/connectors
Francis Genet (frifriSF59)
changed the title
Contributor
Author
|
/format-fix
|
Octavia Squidington III (octavia-squidington-iii)
added
the
area/documentation
Francis Genet (frifriSF59)
enabled auto-merge (squash)
January 9, 2025 18:29
Edward Gao (edgao)
approved these changes
Jan 9, 2025
Edward Gao (edgao)
left a comment
Edward Gao (edgao)
left a comment
Contributor
There was a problem hiding this comment.
probably also worth renaming e.g. IcebergDestination -> S3DataLakeDestination? otherwise lgtm
…g with S3DataLakeDestinationCleaner
Francis Genet (frifriSF59)
deleted the
frifri/s3-data-lake-folder-cleanup
branch
January 9, 2025 19:44
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Update all occurrences of
iceberg.v2in our code since it should now be called s3-data-lakeCan this PR be safely reverted and rolled back?
Closes https://github.com/airbytehq/airbyte-internal-issues/issues/11314