Destination S3 Data Lake: quickfix to clarify config options - #51595
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Octavia Squidington III (octavia-squidington-iii)
added
area/connectors
f68b76b to
d60c753
Compare
Octavia Squidington III (octavia-squidington-iii)
added
the
area/documentation
| @get:JsonPropertyDescription( | ||
| "The root location of the data warehouse used by the Iceberg catalog." | ||
| @get:JsonSchemaDescription( | ||
| """The root location of the data warehouse used by the Iceberg catalog. Typically includes a bucket name and path within that bucket. Must include the storage protocol (such as "s3://" for Amazon S3).""" |
There was a problem hiding this comment.
Should we use something like this to give an example instead?
There was a problem hiding this comment.
ugh. missed this comment. yes, that would be better - I'll make another pr 🤦
There was a problem hiding this comment.
oh. actually - it looks like we already have that? https://github.com/airbytehq/airbyte/blob/master/airbyte-integrations/connectors/destination-s3-data-lake/src/main/kotlin/io/airbyte/integrations/destination/s3_data_lake/S3DataLakeSpecification.kt#L57
There was a problem hiding this comment.
.... oh, that's from this PR <.<
the spec stuff is pretty confusing. S3DataLakeSpec overrides IcebergCatalogSpec, so it inherits this description, then adds the example value
3 participants
warehouse location + branch name aren't super intuitive, make that better.
(see beta channel https://airbytehq-team.slack.com/archives/C087GAG7X25/p1737051609711289)