Destination S3 Data Lake: handle more weird characters in stream name/ns - #52690
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Octavia Squidington III (octavia-squidington-iii)
added
area/connectors
Octavia Squidington III (octavia-squidington-iii)
added
the
CDK
Francis Genet (frifriSF59)
approved these changes
Jan 31, 2025
Francis Genet (frifriSF59)
left a comment
Francis Genet (frifriSF59)
left a comment
Contributor
There was a problem hiding this comment.
I think you'll need to increment the version.
LGTM otherwise
Octavia Squidington III (octavia-squidington-iii)
added
the
area/documentation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes https://github.com/airbytehq/airbyte-internal-issues/issues/11439
afaict: glue is actually fine with weird chars, but has an in-client validation that requires alphanumeric+underscore for some reason? (nessie doesn't seem to have this validation - it's specifically in this IcebergToGlueConverter class, from the iceberg-aws library)
(some of this might want to get extracted to the CDK eventually? but putting it here for now)
example error:
