Destination S3 Data Lake: improve error message on null PK - #53164
Merged
Conversation
Edward Gao (edgao)
requested review from
Francis Genet (frifriSF59) and
Subodh Chaturvedi (subodh1810)
February 4, 2025 17:39
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Octavia Squidington III (octavia-squidington-iii)
added
area/connectors
Edward Gao (edgao)
force-pushed
the
edgao/iceberg_null_pk
branch
from
February 4, 2025 18:03
52cbb9a to
c78e514
Compare
Octavia Squidington III (octavia-squidington-iii)
added
the
area/documentation
Edward Gao (edgao)
changed the base branch from
master
to
edgao/glue_funky_characters
February 4, 2025 18:03
Edward Gao (edgao)
force-pushed
the
edgao/iceberg_null_pk
branch
from
February 4, 2025 18:26
c78e514 to
08cb957
Compare
Octavia Squidington III (octavia-squidington-iii)
removed
area/documentation
Octavia Squidington III (octavia-squidington-iii)
added
the
area/documentation
Subodh Chaturvedi (subodh1810)
approved these changes
Feb 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes https://github.com/airbytehq/airbyte-internal-issues/issues/11555.
currently we just throw an NPE, which is confusing, and also triggers retries https://airbytehq-team.slack.com/archives/C087GAG7X25/p1738632947654209
catch the error, give it a nice message, and rethrow as ConfigError to prevent retries. Also add a test case.
(Subodh Chaturvedi (@subodh1810) tagging you b/c you wrote the dedup code :P I'm pretty sure this is the best place to add this handling, but lmk if somewhere else makes more sense)