Skip to content

[source-facebook-marketing] Log Utilization type - #53626

Merged
M. Marx (marcosmarxm) merged 4 commits into
airbytehq:masterfrom
szemek:api-utilization
Feb 12, 2025
Merged

[source-facebook-marketing] Log Utilization type#53626
M. Marx (marcosmarxm) merged 4 commits into
airbytehq:masterfrom
szemek:api-utilization

Conversation

@szemek

@szemek Przemysław Dąbek (szemek) commented Feb 11, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

What

Logging precisely utilization type.

There were some questions about this warning:
https://airbytehq.slack.com/archives/C021JANJ6TY/p1739242111784099
https://airbytehq.slack.com/archives/C021JANJ6TY/p1734513075065149

How

Just added Facebook API in front of Utilization 😉

Review guide

  1. airbyte-integrations/connectors/source-facebook-marketing/source_facebook_marketing/api.py

User Impact

Tiny, but it helps people to know what this warning is all about.

Can this PR be safely reverted and rolled back?

  • YES 💚
  • NO ❌

@szemek
Przemysław Dąbek (szemek) requested a review from a team as a code owner February 11, 2025 07:45
@vercel

vercel Bot commented Feb 11, 2025

Copy link
Copy Markdown

Przemysław Dąbek (@szemek) is attempting to deploy a commit to the Airbyte Growth Team on Vercel.

A member of the Team first needs to authorize it.

@szemek Przemysław Dąbek (szemek) changed the title [source-facebook-marketing] API utilization [source-facebook-marketing] Log Utilization type Feb 11, 2025
@octavia-squidington-iii Octavia Squidington III (octavia-squidington-iii) added the area/documentation Improvements or additions to documentation label Feb 11, 2025
marcosmarxm
M. Marx (marcosmarxm) approved these changes Feb 11, 2025
View reviewed changes

@marcosmarxm M. Marx (marcosmarxm) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vercel

vercel Bot commented Feb 11, 2025 •
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 12, 2025 0:38am

@marcosmarxm
M. Marx (marcosmarxm) enabled auto-merge (squash) February 12, 2025 12:33
@marcosmarxm
M. Marx (marcosmarxm) merged commit 3f9adbb into airbytehq:master Feb 12, 2025
@szemek
Przemysław Dąbek (szemek) deleted the api-utilization branch February 12, 2025 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lazebnyi Serhii Lazebnyi (lazebnyi) lazebnyi approved these changes
+1 more reviewer
@marcosmarxm M. Marx (marcosmarxm) marcosmarxm approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area/connectors Connector related issues area/documentation Improvements or additions to documentation community connectors/source/facebook-marketing

Projects

🧑‍🏭 Community Pull Requests
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@szemek @marcosmarxm @lazebnyi @octavia-squidington-iii