Skip to content

[Destination MSSQL] v2 rc8 - #54186

Merged
Jimmy Ma (gosusnp) merged 8 commits into
masterfrom
move/destination-mssql-v2-rc8
Feb 20, 2025
Merged

Jimmy Ma (gosusnp) merged 8 commits into
masterfrom
move/destination-mssql-v2-rc8

Conversation

@gosusnp

Copy link
Copy Markdown
Contributor

What

RC8:

  • Address a MSSQL restriction where index have a size restriction and do not support VARCHAR(max) columns: we now default to using VARCHAR(200) for columns that are part of an index.

Can this PR be safely reverted and rolled back?

  • YES 💚
  • NO ❌

@vercel

vercel Bot commented Feb 20, 2025 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 20, 2025 11:12pm

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@gosusnp

Jimmy Ma (gosusnp) commented Feb 20, 2025 •

Copy link
Copy Markdown
Contributor Author

/format-fix

Format-fix job started... Check job output.

✅ Changes applied successfully. (8a5689a)

@edgao Edward Gao (edgao) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test lgtm, didn't read the rest of the pr

also submitted https://github.com/airbytehq/airbyte-internal-issues/issues/11750 to do this for all the other types >.>

@gosusnp
Jimmy Ma (gosusnp) merged commit e666f19 into master Feb 20, 2025
@gosusnp
Jimmy Ma (gosusnp) deleted the move/destination-mssql-v2-rc8 branch February 20, 2025 23:27

This branch was successfully deployed

1 active deployment
Preview — a33c8763 Deployed Feb 20, 2025 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/connectors Connector related issues area/documentation Improvements or additions to documentation CDK Connector Development Kit connectors/destination/mssql-v2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants