Repository navigation
[Destination MSSQL] v2 rc8 - #54186
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
Author
|
/format-fix
|
Edward Gao (edgao)
approved these changes
Feb 20, 2025
Edward Gao (edgao)
left a comment
Contributor
There was a problem hiding this comment.
test lgtm, didn't read the rest of the pr
also submitted https://github.com/airbytehq/airbyte-internal-issues/issues/11750 to do this for all the other types >.>
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
RC8:
VARCHAR(max)columns: we now default to usingVARCHAR(200)for columns that are part of an index.Can this PR be safely reverted and rolled back?