Skip to content

fix: avoid hyphens in index name - #54648

Merged
Jonathan Pearlin (jdpgrailsdev) merged 4 commits into
masterfrom
move/destination-mssql-v2-rc10
Feb 24, 2025
Merged

fix: avoid hyphens in index name#54648
Jonathan Pearlin (jdpgrailsdev) merged 4 commits into
masterfrom
move/destination-mssql-v2-rc10

Conversation

@jdpgrailsdev

@jdpgrailsdev Jonathan Pearlin (jdpgrailsdev) commented Feb 24, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

What

  • Avoid invalid characters in index names

How

  • Ensure that column hashcode value cannot contain hyphens. While there is a risk of collisions, this should be minimal given that we are only dealing with a handful of columns at a time.

Review guide

  1. MSSQLQueryBuilder.kt

Can this PR be safely reverted and rolled back?

  • YES 💚
  • NO ❌

@vercel

vercel Bot commented Feb 24, 2025 •
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 24, 2025 5:59pm

@octavia-squidington-iii Octavia Squidington III (octavia-squidington-iii) added the area/documentation Improvements or additions to documentation label Feb 24, 2025
@jdpgrailsdev
Jonathan Pearlin (jdpgrailsdev) deleted the move/destination-mssql-v2-rc10 branch February 24, 2025 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@subodh1810 Subodh Chaturvedi (subodh1810) Awaiting requested review from subodh1810
1 more reviewer
@gosusnp Jimmy Ma (gosusnp) gosusnp approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/destination/mssql-v2

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jdpgrailsdev @gosusnp @octavia-squidington-iii