Skip to content

[source-mysql] More meaningful errors for variables used in extra checks for CDC - #55731

Merged
M. Marx (marcosmarxm) merged 3 commits into
airbytehq:masterfrom
szemek:source-mysql-errors
Mar 14, 2025
Merged

[source-mysql] More meaningful errors for variables used in extra checks for CDC#55731
M. Marx (marcosmarxm) merged 3 commits into
airbytehq:masterfrom
szemek:source-mysql-errors

Conversation

@szemek

@szemek Przemysław Dąbek (szemek) commented Mar 12, 2025

Copy link
Copy Markdown
Contributor

What

More meaningful errors for source-mysql connector.

Motivation:
https://airbytehq.slack.com/archives/C021JANJ6TY/p1741784591500319

Instead of

image

it's way better to provide the name of variable

image

How

Passing variable name to an exception.

Review guide

  1. airbyte-integrations/connectors/source-mysql/src/main/kotlin/io/airbyte/integrations/source/mysql/MySqlSourceMetadataQuerier.kt

User Impact

Improvement for connector users.

Can this PR be safely reverted and rolled back?

  • YES 💚
  • NO ❌

@szemek
Przemysław Dąbek (szemek) requested a review from a team as a code owner March 12, 2025 20:36
@vercel

vercel Bot commented Mar 12, 2025

Copy link
Copy Markdown

Przemysław Dąbek (@szemek) is attempting to deploy a commit to the Airbyte Growth Team on Vercel.

A member of the Team first needs to authorize it.

@szemek Przemysław Dąbek (szemek) changed the title [source-mysql] Provide more meaningful errors [source-mysql] More meaningful errors for variables used in extra checks for CDC Mar 12, 2025
marcosmarxm
M. Marx (marcosmarxm) reviewed Mar 13, 2025
View reviewed changes

@marcosmarxm M. Marx (marcosmarxm) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this QOL. Yue Li (@theyueli) can we add this to the team sprint to review?

theyueli
Yue Li (theyueli) approved these changes Mar 13, 2025
View reviewed changes

@theyueli Yue Li (theyueli) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for this enhancement!

@github-project-automation github-project-automation Bot moved this from Backlog to Ready to Ship in 🧑‍🏭 Community Pull Requests Mar 13, 2025
@theyueli

Yue Li (theyueli) commented Mar 13, 2025

Copy link
Copy Markdown
Contributor

M. Marx (@marcosmarxm) looks good to me, please help ensure CI and checks run well, and we resolve the conflict by bumping up to the correct version. Thanks!

@vercel

vercel Bot commented Mar 13, 2025 •
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 14, 2025 4:01pm

@szemek

Przemysław Dąbek (szemek) commented Mar 13, 2025

Copy link
Copy Markdown
Contributor Author

I reverted one commit to make SpotBugs happy. It didn't like interpolated strings in SQL queries and I completely understand that.
image

@marcosmarxm
M. Marx (marcosmarxm) merged commit 7c51ec1 into airbytehq:master Mar 14, 2025
@github-project-automation github-project-automation Bot moved this from Ready to Ship to Done in 🧑‍🏭 Community Pull Requests Mar 14, 2025
@szemek
Przemysław Dąbek (szemek) deleted the source-mysql-errors branch March 14, 2025 17:18
Sven Pöche (Valgard) pushed a commit to mayflower/airbyte that referenced this pull request Mar 25, 2025
@szemek @Valgard
[source-mysql] More meaningful errors for variables used in extra che…
b36e712 
…cks for CDC (airbytehq#55731)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yardencarmeli Yarden Carmeli (yardencarmeli) Awaiting requested review from yardencarmeli
@mwbayley Matt Bayley (mwbayley) Awaiting requested review from mwbayley
2 more reviewers
@marcosmarxm M. Marx (marcosmarxm) marcosmarxm left review comments
@theyueli Yue Li (theyueli) theyueli approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

community connectors/source/mysql

Projects

🧑‍🏭 Community Pull Requests
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@szemek @theyueli @marcosmarxm @octavia-squidington-iii