Repository navigation
Load-CDK/Dest-S3: Sync Hangs on OOM sometimes - #55875
Merged
Johnny Schmidt (johnny-schmidt) merged 1 commit intoMar 20, 2025
Merged
Johnny Schmidt (johnny-schmidt) merged 1 commit into
Johnny Schmidt (johnny-schmidt) merged 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Johnny Schmidt (johnny-schmidt)
force-pushed
the
jschmidt/load-cdk-dest-s3/handle-throwable
branch
from
March 20, 2025 17:20
65d7b83 to
7e05182
Compare
Edward Gao (edgao)
approved these changes
Mar 20, 2025
Edward Gao (edgao)
left a comment
Edward Gao (edgao)
left a comment
Contributor
There was a problem hiding this comment.
as hotfix, but also I thought we enabled the "kill JVM on OOM" option :/ so it's surprising that we even need to handle this case.
(in general I dislike catching OOM, b/c at that point, you're decently likely to just throw another OOM when you e.g. make a new string log message)
Contributor
|
yeah, we have |
Johnny Schmidt (johnny-schmidt)
deleted the
jschmidt/load-cdk-dest-s3/handle-throwable
branch
March 20, 2025 17:50
Sven Pöche (Valgard)
pushed a commit
to mayflower/airbyte
that referenced
this pull request
Mar 25, 2025
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Addresses https://github.com/airbytehq/oncall/issues/7133
If a Throwable (not Exception) is thrown from a load CDK task, exception handling won't run and won't shut down tasks. It seems like under some conditions this results in the process not shutting down properly after an OOM.
Artificially injecting a throwable into the worker tasks or the open-stream task will cause ITs to hang.
Alarmingly, injecting any exception into the close-stream task might not cause tests to fail. Opened https://github.com/airbytehq/airbyte-internal-issues/issues/12115 to track.