Repository navigation
Integrate with the latest mssql jdbc driver to fix historical dates parsing - #55878
Merged
Rodi Reich Zilberman (rodireich) merged 7 commits intoMar 20, 2025
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| .addExpectedValues("2001-01-10T00:00:00.000000+01:00", | ||
| "9999-01-10T00:00:00.000000+01:00", null, "2024-05-10T19:00:01.604805+03:00", "2024-03-02T19:08:07.123456+09:00", | ||
| "2024-03-02T19:08:07.123456+09:00") | ||
| "2024-03-02T19:08:07.123456+09:00", "0001-01-01T00:00:00.000000Z") |
Contributor
Author
There was a problem hiding this comment.
Before the MS driver fix this is coming back as 0001-12-30T00:00:00.000000Z BC.
Rodi Reich Zilberman (rodireich)
changed the title
Rodi Reich Zilberman (rodireich)
marked this pull request as ready for review
March 20, 2025 20:16
Rodi Reich Zilberman (rodireich)
requested a review
from a team
as a code owner
March 20, 2025 20:16
Yue Li (theyueli)
approved these changes
Mar 20, 2025
Yue Li (theyueli)
left a comment
Yue Li (theyueli)
left a comment
Contributor
There was a problem hiding this comment.
thanks for the fix!!
Rodi Reich Zilberman (rodireich)
deleted the
6610-source-mssql---datetimeoffset-value-parsed-incorrectly
branch
March 20, 2025 20:20
Sven Pöche (Valgard)
pushed a commit
to mayflower/airbyte
that referenced
this pull request
Mar 25, 2025
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Ensure pre-gregorian dates are not read with an offset.
How
Microsoft fixed a bug on their driver. Integrate source-mssql with the now fixed 12.10.0.
User Impact
Users with historical value (before Oct 4th 1582) should refresh their data as previously the value might have been read incorrectly.
All other dates are not affected.
Can this PR be safely reverted and rolled back?