Repository navigation
Bulk load CDK: Fix testUnknownTypes - #55904
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| @Test | ||
| override fun testUnknownTypes() { | ||
| super.testUnknownTypes() | ||
| } |
Sven Pöche (Valgard)
pushed a commit
to mayflower/airbyte
that referenced
this pull request
Mar 25, 2025
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AirbyteTypeToJsonSchema was previously discarding the input schema, so we ran with a field of type
{}. Which for some reason we treat as ObjectWithEmptySchema? but w/ethis meant that testUnknownTypes was actually testing behavior on ObjectWithEmptySchema.
Also, update mssql to actually serialize UNKNOWN values in standard inserts mode. IMO we can release this without doing a breaking change. (I'll implement bulk inserts in #55884)