Dest-MSSQL: MSSQL Uses BulkLoader Interface - #56353
Merged
Johnny Schmidt (johnny-schmidt) merged 1 commit intoApr 2, 2025
Merged
Johnny Schmidt (johnny-schmidt) merged 1 commit into
Johnny Schmidt (johnny-schmidt) merged 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Johnny Schmidt (johnny-schmidt)
force-pushed
the
jschmidt/dest-mssql/mssql-uses-bulk-load
branch
from
March 23, 2025 21:30
05373cc to
86edc20
Compare
Johnny Schmidt (johnny-schmidt)
force-pushed
the
jschmidt/dest-mssql/mssql-uses-bulk-load
branch
from
March 23, 2025 22:25
86edc20 to
fdf2ed1
Compare
Johnny Schmidt (johnny-schmidt)
force-pushed
the
jschmidt/dest-mssql/mssql-uses-bulk-load
branch
from
March 23, 2025 22:34
fdf2ed1 to
eddfa04
Compare
Johnny Schmidt (johnny-schmidt)
marked this pull request as ready for review
March 23, 2025 22:37
Johnny Schmidt (johnny-schmidt)
force-pushed
the
jschmidt/dest-mssql/mssql-uses-bulk-load
branch
from
March 23, 2025 23:36
eddfa04 to
fff4705
Compare
Johnny Schmidt (johnny-schmidt)
force-pushed
the
jschmidt/dest-mssql/mssql-uses-bulk-load
branch
from
March 24, 2025 16:05
fff4705 to
bf0e6be
Compare
Johnny Schmidt (johnny-schmidt)
force-pushed
the
jschmidt/load-cdk/bulk-load-interface
branch
from
March 24, 2025 19:41
521ecaa to
e495fdd
Compare
Johnny Schmidt (johnny-schmidt)
force-pushed
the
jschmidt/dest-mssql/mssql-uses-bulk-load
branch
from
March 24, 2025 19:46
bf0e6be to
a2c9ed0
Compare
Johnny Schmidt (johnny-schmidt)
force-pushed
the
jschmidt/dest-mssql/mssql-uses-bulk-load
branch
from
March 24, 2025 20:32
a2c9ed0 to
7136bb5
Compare
Johnny Schmidt (johnny-schmidt)
force-pushed
the
jschmidt/load-cdk/bulk-load-interface
branch
from
March 24, 2025 20:53
e495fdd to
e277af2
Compare
Johnny Schmidt (johnny-schmidt)
force-pushed
the
jschmidt/dest-mssql/mssql-uses-bulk-load
branch
from
March 24, 2025 20:59
7136bb5 to
ad6bf14
Compare
Johnny Schmidt (johnny-schmidt)
force-pushed
the
jschmidt/load-cdk/bulk-load-interface
branch
2 times, most recently
from
March 25, 2025 21:44
e0ef829 to
f84a68f
Compare
Johnny Schmidt (johnny-schmidt)
force-pushed
the
jschmidt/dest-mssql/mssql-uses-bulk-load
branch
from
March 25, 2025 21:53
ad6bf14 to
10cf83c
Compare
Johnny Schmidt (johnny-schmidt)
requested a review
from Subodh Chaturvedi (subodh1810)
March 25, 2025 22:02
Johnny Schmidt (johnny-schmidt)
force-pushed
the
jschmidt/load-cdk/bulk-load-interface
branch
from
March 27, 2025 17:56
f84a68f to
1287217
Compare
Johnny Schmidt (johnny-schmidt)
force-pushed
the
jschmidt/dest-mssql/mssql-uses-bulk-load
branch
from
March 27, 2025 18:18
10cf83c to
a7b5381
Compare
Johnny Schmidt (johnny-schmidt)
force-pushed
the
jschmidt/dest-mssql/mssql-uses-bulk-load
branch
from
March 27, 2025 20:11
a7b5381 to
95f429e
Compare
Johnny Schmidt (johnny-schmidt)
force-pushed
the
jschmidt/dest-mssql/mssql-uses-bulk-load
branch
4 times, most recently
from
March 27, 2025 20:20
bb164b4 to
258d44c
Compare
Johnny Schmidt (johnny-schmidt)
force-pushed
the
jschmidt/load-cdk/bulk-load-interface
branch
from
March 27, 2025 20:31
31913e5 to
2ab32ca
Compare
Johnny Schmidt (johnny-schmidt)
force-pushed
the
jschmidt/dest-mssql/mssql-uses-bulk-load
branch
from
March 27, 2025 20:32
258d44c to
ef6d9ca
Compare
Johnny Schmidt (johnny-schmidt)
force-pushed
the
jschmidt/load-cdk/bulk-load-interface
branch
from
March 28, 2025 17:51
2ab32ca to
364c547
Compare
Base automatically changed from
jschmidt/load-cdk/bulk-load-interface
to
master
March 28, 2025 17:57
Johnny Schmidt (johnny-schmidt)
force-pushed
the
jschmidt/dest-mssql/mssql-uses-bulk-load
branch
from
March 28, 2025 17:59
ef6d9ca to
c7c25f3
Compare
Johnny Schmidt (johnny-schmidt)
force-pushed
the
jschmidt/dest-mssql/mssql-uses-bulk-load
branch
from
March 28, 2025 19:05
c7c25f3 to
0d82af4
Compare
Johnny Schmidt (johnny-schmidt)
force-pushed
the
jschmidt/dest-mssql/mssql-uses-bulk-load
branch
2 times, most recently
from
March 28, 2025 20:03
e650f75 to
4bac608
Compare
Subodh Chaturvedi (subodh1810)
approved these changes
Apr 1, 2025
Johnny Schmidt (johnny-schmidt)
force-pushed
the
jschmidt/dest-mssql/mssql-uses-bulk-load
branch
from
April 1, 2025 21:47
4bac608 to
c9b831a
Compare
Johnny Schmidt (johnny-schmidt)
force-pushed
the
jschmidt/dest-mssql/mssql-uses-bulk-load
branch
from
April 1, 2025 22:04
c9b831a to
0ed47b2
Compare
Johnny Schmidt (johnny-schmidt)
deleted the
jschmidt/dest-mssql/mssql-uses-bulk-load
branch
April 2, 2025 23:48
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
MSSQL Uses the BulkLoader interface described here .
This basically just moves the work that was being done for bulk load in the BulkLoaderStreamLoader into
MSSQLBulkLoader. Start/close still live in the stream loader. A small statestore is broken out to pass info from start/close to the factory. Additionally there's some micronaut magic to make it possible to conditionally inject a bean based on whether we're configured for BulkLoad.This has been heavily tested, all relevant fixes and improvements are in underlying PRs. Expect a slight perf improvement in the cloud. (Also I verified that I didn't break StandardInsert.)