Skip to content

chore(destination): Upgrade all Java destination connectors to use java-connector-base:2.0.1 - #56355

Merged
Davin Chia (davinchia) merged 9 commits into
masterfrom
devin/1742773952-update-java-destination-connectors
Mar 24, 2025
Merged

chore(destination): Upgrade all Java destination connectors to use java-connector-base:2.0.1#56355
Davin Chia (davinchia) merged 9 commits into
masterfrom
devin/1742773952-update-java-destination-connectors

Conversation

@devin-ai-integration

@devin-ai-integration devin-ai-integration Bot commented Mar 23, 2025

Copy link
Copy Markdown
Contributor

This PR updates all Java destination connectors to use docker.io/airbyte/java-connector-base:2.0.1@sha256:ec89bd1a89e825514dd2fc8730ba299a3ae1544580a078df0e35c5202c2085b3.

The update is for compatibility with Apple M4 architecture.

Link to Devin run: https://app.devin.ai/sessions/3d739e478dbc42a981995321fa2edb69
Requested by: davin@airbyte.io

@devin-ai-integration @octavia-squidington-iii
chore(destination): Upgrade all Java destination connectors to use ja…
837af66 
…va-connector-base:2.0.1 for M4 compatibility

Co-Authored-By: davin@airbyte.io <davin@airbyte.io>
@devin-ai-integration
devin-ai-integration Bot requested a review from a team as a code owner March 23, 2025 23:53
@devin-ai-integration

devin-ai-integration Bot commented Mar 23, 2025

Copy link
Copy Markdown
Contributor Author

🤖 Devin AI Engineer

Original prompt from davin@airbyte.io:

Within the airbyte repo, I want you to upgrade all the java destination connectors to use docker.io/airbyte/java-connector-base:2.0.1@sha256:ec89bd1a89e825514dd2fc8730ba299a3ae1544580a078df0e35c5202c2085b3.

Only target destination connectors with baseImage set in the metadata.yaml file.

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add "(aside)" to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

@vercel

vercel Bot commented Mar 23, 2025 •
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 24, 2025 8:44pm

@davinchia

Davin Chia (davinchia) commented Mar 23, 2025

Copy link
Copy Markdown
Contributor

For all the Destination connectors, please also bump the patch version in each destination connector's metadata.yaml. Please also update the changelog in the relevant destination connector's docs.

You can use this PR as an example.

@davinchia

Davin Chia (davinchia) commented Mar 23, 2025

Copy link
Copy Markdown
Contributor

https://github.com/airbytehq/airbyte/pull/55906/files#diff-975f6fa55a558ac4966a6b0607351bfc541eb508982c0b5d75ca3e9af586a91d is the PR.

@devin-ai-integration

devin-ai-integration Bot commented Mar 24, 2025

Copy link
Copy Markdown
Contributor Author

/bump-version

@devin-ai-integration

devin-ai-integration Bot commented Mar 24, 2025

Copy link
Copy Markdown
Contributor Author

I've added the /bump-version command to automatically update all connector versions and changelogs. Waiting for the bot to process this request.

@devin-ai-integration

devin-ai-integration Bot commented Mar 24, 2025

Copy link
Copy Markdown
Contributor Author

Since the /bump-version command hasn't processed yet, I'll manually implement the version bumps and changelog updates for all 18 Java destination connectors. This will ensure we address davinchia's feedback promptly.

@devin-ai-integration devin-ai-integration Bot mentioned this pull request Mar 24, 2025
Merged
@devin-ai-integration devin-ai-integration Bot mentioned this pull request Mar 24, 2025
Closed
@devin-ai-integration @octavia-squidington-iii @davinchia
chore(destination): Bump patch versions and add changelog entries for…
cf45565 
… Java destination connectors (#56356)

Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Co-authored-by: davin@airbyte.io <davin@airbyte.io>
Co-authored-by: Davin Chia <davinchia@gmail.com>
davinchia
Davin Chia (davinchia) reviewed Mar 24, 2025
View reviewed changes
Comment thread airbyte-integrations/connectors/destination-mysql-strict-encrypt/metadata.yaml

@davinchia Davin Chia (davinchia) Mar 24, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(aside) I'm not 100% sure about the strict-encrypt flows. This feels correct pattern matching off existing code,

@edgao Edward Gao (edgao) Mar 24, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is unfortunately correct. At some point we might want to merge the strict-encrypt variants into the base connectors, and programmatically switch behaviors - hasn't been a priority though.

edgao
Edward Gao (edgao) approved these changes Mar 24, 2025
View reviewed changes
Comment thread airbyte-integrations/connectors/destination-mysql-strict-encrypt/metadata.yaml

@edgao Edward Gao (edgao) Mar 24, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is unfortunately correct. At some point we might want to merge the strict-encrypt variants into the base connectors, and programmatically switch behaviors - hasn't been a priority though.

@davinchia
Davin Chia (davinchia) merged commit ceaf322 into master Mar 24, 2025
@davinchia
Davin Chia (davinchia) deleted the devin/1742773952-update-java-destination-connectors branch March 24, 2025 22:59
Sven Pöche (Valgard) pushed a commit to mayflower/airbyte that referenced this pull request Mar 25, 2025
@devin-ai-integration @octavia-squidington-iii
@davinchia @Valgard
chore(destination): Upgrade all Java destination connectors to use ja…
ec1c0e9 
…va-connector-base:2.0.1 (airbytehq#56355)

Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Co-authored-by: davin@airbyte.io <davin@airbyte.io>
Co-authored-by: Davin Chia <davinchia@gmail.com>

This branch was successfully deployed

1 active deployment
Preview — 00e1d9b2 Deployed Mar 24, 2025 by vercel[bot]
View deployment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment