Skip to content

Update SAS Token documentation for BULK INSERT Load type - #57563

Merged
M. Marx (marcosmarxm) merged 19 commits into
airbytehq:masterfrom
plovegro:plovegro/docs/bulk-load-blob-storage
Apr 17, 2025
Merged

Update SAS Token documentation for BULK INSERT Load type#57563
M. Marx (marcosmarxm) merged 19 commits into
airbytehq:masterfrom
plovegro:plovegro/docs/bulk-load-blob-storage

Conversation

@plovegro

@plovegro plovegro commented Apr 10, 2025

Copy link
Copy Markdown
Contributor

Add accurate example of an SAS token to be used in BULK Load insert configuration.

What

This is a simply documentation update. At the moment the example given can lead the user down a rabbit hole. It suggests a 'key' that looks like the sig portion of a SAS token. However, the entire SAS token needs to be used.
#56912

How

Documentation update with a more accurate SAS token example.
This brings it more inline with this documentation https://docs.airbyte.com/integrations/destinations/mssql#configuration which clearly states the value needs to be a SAS token.

Review guide

Compare old example to new example.

User Impact

This will enable a more seamless set up process of BULK LOAD, and lead to less wasted time for users.

Can this PR be safely reverted and rolled back?

  • [X ] YES 💚
  • NO ❌

@plovegro
plovegro requested a review from a team as a code owner April 10, 2025 14:23
@vercel

vercel Bot commented Apr 10, 2025

Copy link
Copy Markdown

plovegro is attempting to deploy a commit to the Airbyte Growth Team on Vercel.

A member of the Team first needs to authorize it.

@plovegro
plovegro temporarily deployed to community-ci-auto April 10, 2025 14:23 — with GitHub Actions Inactive
@plovegro plovegro changed the title Plovegro/docs/bulk load blob storage Update SAS Token for BLOB INSERT Load type Apr 10, 2025
@plovegro
plovegro temporarily deployed to community-ci-auto April 10, 2025 14:26 — with GitHub Actions Inactive
@plovegro plovegro changed the title Update SAS Token for BLOB INSERT Load type Update SAS Token documentation for BULK INSERT Load type Apr 10, 2025
@plovegro

plovegro commented Apr 10, 2025

Copy link
Copy Markdown
Contributor Author

Previously logged but accidentally reverted on fork - my bad

edgao
Edward Gao (edgao) approved these changes Apr 10, 2025
View reviewed changes

@edgao Edward Gao (edgao) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

M. Marx (@marcosmarxm) I think this is a refire of #56933 - diff still LGTM, iirc the only blocker on the previous PR was getting CI to run?

@github-project-automation github-project-automation Bot moved this from Backlog to Ready to Ship in 🧑‍🏭 Community Pull Requests Apr 10, 2025
@vercel

vercel Bot commented Apr 10, 2025 •
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 17, 2025 8:07pm

@plovegro
plovegro temporarily deployed to community-ci-auto April 10, 2025 21:45 — with GitHub Actions Inactive
@plovegro
plovegro temporarily deployed to community-ci-auto April 12, 2025 06:50 — with GitHub Actions Inactive
@marcosmarxm

M. Marx (marcosmarxm) commented Apr 14, 2025

Copy link
Copy Markdown
Contributor

Running tests again plovegro any news I'll return to you

@edgao

Edward Gao (edgao) commented Apr 15, 2025

Copy link
Copy Markdown
Contributor

pushed 473d1f3, which should fix the build

  • destination-azure-blob-storage now uses local CDK instead of a pinned CDK version, I'll submit a PR later to re-pin it
  • also regenerated the spec files. The test has some strict formatting requirements

@marcosmarxm

M. Marx (marcosmarxm) commented Apr 15, 2025

Copy link
Copy Markdown
Contributor

I triggered ci tests Edward Gao (@edgao)

@marcosmarxm
M. Marx (marcosmarxm) merged commit 4e1827d into airbytehq:master Apr 17, 2025
@github-project-automation github-project-automation Bot moved this from Ready to Ship to Done in 🧑‍🏭 Community Pull Requests Apr 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@edgao Edward Gao (edgao) edgao approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

community connectors/destination/azure-blob-storage connectors/destination/mssql

Projects

🧑‍🏭 Community Pull Requests
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@plovegro @marcosmarxm @edgao @octavia-squidington-iii