Skip to content

🐛 Destination snowflake: updated snowflake query timeout - #5784

Merged
andriikorotkov merged 4 commits into
masterfrom
akorotkov/4745-snowflake-destination-query-timeout-fix
Sep 3, 2021
Merged

andriikorotkov merged 4 commits into
masterfrom
akorotkov/4745-snowflake-destination-query-timeout-fix

Conversation

@andriikorotkov

@andriikorotkov andriikorotkov commented Sep 1, 2021 •

Copy link
Copy Markdown
Contributor

What

Sync succeeded but destination snowflake tables are empty

How

Updated query timeout from 30 minutes to 3 hours. It is first part of fix this bug.

Pre-merge Checklist

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions
  • Connector version bumped like described here

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here

@github-actions github-actions Bot added the area/documentation Improvements or additions to documentation label Sep 1, 2021

@etsybaev Eugene (etsybaev) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but please make sure all check\tests passed before moving forward. I would also add new timeout info to the main connector's documentation explicitly

@andriikorotkov
andriikorotkov marked this pull request as ready for review September 2, 2021 07:32
…4745-snowflake-destination-query-timeout-fix
@andriikorotkov

andriikorotkov commented Sep 2, 2021 •

Copy link
Copy Markdown
Contributor Author

/test connector=connectors/destination-snowflake

🕑 connectors/destination-snowflake https://github.com/airbytehq/airbyte/actions/runs/1195020097
✅ connectors/destination-snowflake https://github.com/airbytehq/airbyte/actions/runs/1195020097

@jrhizor
Jared Rhizor (jrhizor) temporarily deployed to more-secrets September 2, 2021 16:47 Inactive
@andriikorotkov
andriikorotkov removed the request for review from Liren Tu (tuliren) September 3, 2021 12:39
@andriikorotkov

andriikorotkov commented Sep 3, 2021 •

Copy link
Copy Markdown
Contributor Author

/publish connector=connectors/destination-snowflake

🕑 connectors/destination-snowflake https://github.com/airbytehq/airbyte/actions/runs/1198095600
✅ connectors/destination-snowflake https://github.com/airbytehq/airbyte/actions/runs/1198095600

@jrhizor
Jared Rhizor (jrhizor) temporarily deployed to more-secrets September 3, 2021 13:08 Inactive
@andriikorotkov
andriikorotkov merged commit dc2fa65 into master Sep 3, 2021
@andriikorotkov
andriikorotkov deleted the akorotkov/4745-snowflake-destination-query-timeout-fix branch September 3, 2021 14:20
@sherifnada

Copy link
Copy Markdown
Contributor

andriikorotkov is there a follow up issue for later fixes?

@andriikorotkov

Copy link
Copy Markdown
Contributor Author

Sherif A. Nada (@sherifnada) No, no problem. I have successfully split one query into multiple ones with a user-specified batch size. I pushed these changes in this Pull Request - #5783

This branch was previously deployed

1 inactive deployment
more-secrets — a996e0c7 Deployed Sep 3, 2021 by jrhizor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[DEST Snowflake] - Sync succeeded but destination tables are empty

7 participants