Repository navigation
Migrate to the same Json Schema Generation Plugin. - #59722
Merged
Davin Chia (davinchia) merged 5 commits intoMay 8, 2025
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
|
Davin Chia (davinchia)
changed the title
Contributor
|
Davin Chia (davinchia)
enabled auto-merge (squash)
May 8, 2025 17:33
Davin Chia (davinchia)
disabled auto-merge
May 8, 2025 17:35
Contributor
Author
|
Note: the beta CI failures can be ignored. |
Yarden Carmeli (yardencarmeli)
pushed a commit
that referenced
this pull request
May 21, 2025
These two sources today use different json schema generation plugins from: The general Airbyte Gradle Plugins. The old CDK This is causing issues when using the Plugins in the new flow here: #59716. [Incubating] Problems report is available at: file:///home/runner/work/airbyte/airbyte/build/reports/problems/problems-report.html FAILURE: Build failed with an exception. * What went wrong: Execution failed for task ':airbyte-integrations:connectors:source-***:generateJsonSchema2Pojo'. > Method org/jsonschema2pojo/gradle/JsonSchemaExtension.getTargetLanguage()Lorg/jsonschema2pojo/Language; is abstract Deprecated Gradle features were used in this build, making it incompatible with Gradle 9.0. Instead migrate both of these sources onto the same plugin provider and version. - Migrate both over from org.jsonschema2pojo to com.github.eirnym.js2p. - I also added what seems to be a missing task dependency. I'm not sure why this was never caught before. This is showing up in master as well.
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
These two sources today use different json schema generation plugins from:
This is causing issues when using the Plugins in the new flow here: #59716.
Instead migrate both of these sources onto the same plugin provider and version.
How
org.jsonschema2pojotocom.github.eirnym.js2p.Review guide
All files.
This should be a no-op change since I don't see any change in the generated files so I didn't publish a new version.
I am happy to publish a new version for each connector if people want me to.
User Impact
Can this PR be safely reverted and rolled back?