Repository navigation
Destination Bigquery: RC2 - fix column name handling - #60302
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| // "order" is a reserved word in many sql engines | ||
| "order" to stringType, | ||
| "ProperCase" to stringType, | ||
| "Foo.Bar" to stringType, |
Contributor
Author
There was a problem hiding this comment.
this doesn't actually catch the bug (b/c the bug was specifically in dedup syncs). But it's cheap to add, so why not 🤷
Edward Gao (edgao)
marked this pull request as ready for review
May 15, 2025 20:22
| "" | ||
| } else if (importType.cursor.size == 1) { | ||
| val columnName = importType.cursor.first() | ||
| val columnName = columnNameMapping[importType.cursor.first()]!! |
Contributor
There was a problem hiding this comment.
Nit: No tests for this change?
Contributor
Author
There was a problem hiding this comment.
it's the new testFunkyCharactersDedup case
Ryan Br... (tryangul)
approved these changes
May 15, 2025
Contributor
|
Edward Gao (edgao)
enabled auto-merge (squash)
May 15, 2025 21:22
Yarden Carmeli (yardencarmeli)
pushed a commit
that referenced
this pull request
May 21, 2025
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
two fixes here, in separate commits:
this will fix:
segments.date, which gets turned intosegments_dateallowsMultiUseandAllowsMultiUsealso, intellij told me to declare the
TableIdtype explicitly ontoTableId🤷