Repository navigation
Destination bigquery: RC6: smarter standard inserts implementation to avoid rate limit - #60859
Merged
Francis Genet (frifriSF59) merged 3 commits intoMay 22, 2025
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Francis Genet (frifriSF59)
approved these changes
May 22, 2025
Contributor
|
Francis Genet (frifriSF59)
enabled auto-merge (squash)
May 22, 2025 17:57
Francis Genet (frifriSF59)
changed the title
Francis Genet (frifriSF59)
deleted the
edgao/bigquery_standard_insert_rate_limit
branch
May 22, 2025 18:06
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
standard inserts needs to juggle a few restrictions:
the initial implementation solved the first problem by buffering in a BAOS and flushing to a writechannel when that BAOS hit 15MB - which obviously causes rate limit problems. This implementation keeps the BAOS, but once that BAOS hits 15MB, we switch to writing to a writechannel (so we won't close the channel until we hit the target batch size of 200MB). Which hopefully gets us the best of both worlds.
Important
Auto-merge enabled.
This PR is set to merge automatically when all requirements are met.