Repository navigation
[BigQuery] Add a random element to the check namespace - #60865
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Edward Gao (edgao)
approved these changes
May 22, 2025
Contributor
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
We discovered that we had some failures when a workspace had several destinations in different regions.
This is because in BQ, we are unable to create a dataset with the same name across regions.
So, if a dataset has been created in the EU region, we cannot create it as well in the US region.
This is an issue with the new check since we have a hard coded dataset (
airbyte_internal_test).Adding some random aspect to it should solve the issue. We also need to remember to remove the dataset when running the
BigqueryCheckCleaner. We don't want to pollute our clients BQ instances with a ton of random check datasetsCan this PR be safely reverted and rolled back?
Important
Auto-merge enabled.
This PR is set to merge automatically when all requirements are met.