Skip to content

[source-mssql] Support logical primary key for initial snapshot and CDC - #61729

Merged
Yue Li (theyueli) merged 18 commits into
masterfrom
yue/mssql-logical-pk
Jul 1, 2025
Merged

[source-mssql] Support logical primary key for initial snapshot and CDC#61729
Yue Li (theyueli) merged 18 commits into
masterfrom
yue/mssql-logical-pk

Conversation

@theyueli

@theyueli Yue Li (theyueli) commented Jun 20, 2025

Copy link
Copy Markdown
Contributor

What

CDC is supported through message.key.columns option of Debezium.

@theyueli Yue Li (theyueli) self-assigned this Jun 20, 2025
@theyueli
Yue Li (theyueli) requested a review from a team as a code owner June 20, 2025 19:14
@vercel

vercel Bot commented Jun 20, 2025 •
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Jul 1, 2025 8:27pm

@github-actions

github-actions Bot commented Jun 20, 2025

Copy link
Copy Markdown
Contributor

👋 Greetings, Contributor!

Here are some helpful tips and reminders for your convenience.

Helpful Resources

PR Slash Commands

Airbyte Maintainers (that's you!) can execute the following slash commands on your PR:

  • /format-fix - Fixes most formatting issues.
  • /bump-version - Bumps connector versions.
    • You can specify a custom changelog by passing changelog. Example: /bump-version changelog="My cool update"
    • Leaving the changelog arg blank will auto-populate the changelog from the PR title.
  • /run-cat-tests - Runs legacy CAT tests (Connector Acceptance Tests)
  • /build-connector-images - Builds and publishes a pre-release docker image for the modified connector(s).

📝 Edit this welcome message.

@theyueli

Yue Li (theyueli) commented Jun 20, 2025 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Contributor Author

/bump-version type=patch changelog="Support the use of logical primary keys for CDC."

Bump Version job started... Check job output.

✅ Changes applied successfully. (e619e37)

@github-actions

github-actions Bot commented Jun 20, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

source-mssql Connector Test Results

 22 files   22 suites   17m 59s ⏱️
158 tests 156 ✅ 2 💤 0 ❌
173 runs  171 ✅ 2 💤 0 ❌

Results for commit 0e7d91b.

♻️ This comment has been updated with latest results.

rodireich
Rodi Reich Zilberman (rodireich) reviewed Jun 23, 2025
View reviewed changes

@rodireich Rodi Reich Zilberman (rodireich) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this the entire change?! that's very clean !

Comment thread ...nnectors/source-mssql/src/main/java/io/airbyte/integrations/source/mssql/MssqlCdcHelper.java Outdated
.collect(Collectors.joining(","));
}

private static String quoteIfNeeded(String input) {

@rodireich Rodi Reich Zilberman (rodireich) Jun 23, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this work for a table name containing unicode characters?
can't we just quote everything?

@theyueli Yue Li (theyueli) Jun 27, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

replaced this with a new escape function that escapes ".", ":", ";", ",".

it seems Debezium option can work with unicode..

Comment thread ...nnectors/source-mssql/src/main/java/io/airbyte/integrations/source/mssql/MssqlCdcHelper.java
Comment thread .../connectors/source-mssql/src/main/java/io/airbyte/integrations/source/mssql/MssqlSource.java Outdated
@github-actions

github-actions Bot commented Jun 27, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Note

Detected that there are differences in the Gradle dependencies.

@theyueli
Yue Li (theyueli) requested a review from a team as a code owner June 27, 2025 10:05
@theyueli

Yue Li (theyueli) commented Jun 27, 2025

Copy link
Copy Markdown
Contributor Author

/publish-java-cdk

@theyueli
Yue Li (theyueli) merged commit 7c3b0d1 into master Jul 1, 2025
@theyueli
Yue Li (theyueli) deleted the yue/mssql-logical-pk branch July 1, 2025 20:55
@rkudulis Robertas Kudulis (rkudulis) mentioned this pull request Feb 15, 2026
Open
1 of 2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rodireich Rodi Reich Zilberman (rodireich) rodireich approved these changes
@matteogp Matteo Palarchio (matteogp) Awaiting requested review from matteogp

Assignees

@theyueli Yue Li (theyueli)

Labels

connectors/source/mssql dependencies-change

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@theyueli @rodireich @octavia-squidington-iii