Skip to content

[S3-Data-Lake] Pin to the latest CDK version - #62835

Merged
Francis Genet (frifriSF59) merged 4 commits into
masterfrom
frifri/s3dlpincdk522
Jul 7, 2025
Merged

[S3-Data-Lake] Pin to the latest CDK version#62835
Francis Genet (frifriSF59) merged 4 commits into
masterfrom
frifri/s3dlpincdk522

Conversation

@frifriSF59

@frifriSF59 Francis Genet (frifriSF59) commented Jul 7, 2025 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Contributor

What

Pin the CDK to the latest version now that all tests are passing

Can this PR be safely reverted and rolled back?

  • YES 💚
  • NO ❌

Important

Auto-merge enabled.

This PR is set to merge automatically when all requirements are met.

@frifriSF59
Francis Genet (frifriSF59) requested a review from a team as a code owner July 7, 2025 18:25
@vercel

vercel Bot commented Jul 7, 2025 •
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Jul 7, 2025 7:42pm

@github-actions

github-actions Bot commented Jul 7, 2025

Copy link
Copy Markdown
Contributor

👋 Greetings, Contributor!

Here are some helpful tips and reminders for your convenience.

Helpful Resources

PR Slash Commands

Airbyte Maintainers (that's you!) can execute the following slash commands on your PR:

  • /format-fix - Fixes most formatting issues.
  • /bump-version - Bumps connector versions.
    • You can specify a custom changelog by passing changelog. Example: /bump-version changelog="My cool update"
    • Leaving the changelog arg blank will auto-populate the changelog from the PR title.
  • /run-cat-tests - Runs legacy CAT tests (Connector Acceptance Tests)
  • /build-connector-images - Builds and publishes a pre-release docker image for the modified connector(s).

📝 Edit this welcome message.

@github-actions

github-actions Bot commented Jul 7, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Note

Detected that there are differences in the Gradle dependencies.

@github-actions

github-actions Bot commented Jul 7, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

destination-s3-data-lake Connector Test Results

234 tests   137 ✅  4m 50s ⏱️
 15 suites   97 💤
 15 files      0 ❌

Results for commit 4970834.

♻️ This comment has been updated with latest results.

edgao
Edward Gao (edgao) approved these changes Jul 7, 2025
View reviewed changes

@edgao Edward Gao (edgao) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

trusting you that this is the latest version 🤷

@frifriSF59
Francis Genet (frifriSF59) enabled auto-merge (squash) July 7, 2025 18:48
@frifriSF59

Francis Genet (frifriSF59) commented Jul 7, 2025

Copy link
Copy Markdown
Contributor Author

Yeah -- I used our handy new make command

@frifriSF59
Francis Genet (frifriSF59) merged commit f29c9c5 into master Jul 7, 2025
@frifriSF59
Francis Genet (frifriSF59) deleted the frifri/s3dlpincdk522 branch July 7, 2025 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@edgao Edward Gao (edgao) edgao approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@frifriSF59 Francis Genet (frifriSF59)

Labels

connectors/destination/s3-data-lake dependencies-change

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@frifriSF59 @edgao @octavia-squidington-iii @aaronsteers