[Databricks] Now processing queries in batches in DatabricksDestinationHandler.kt - #63311
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
👋 Greetings, Contributor!Here are some helpful tips and reminders for your convenience. Helpful Resources
PR Slash CommandsAirbyte Maintainers (that's you!) can execute the following slash commands on your PR:
|
Edward Gao (edgao)
left a comment
There was a problem hiding this comment.
maybe worth testing - in AbstractDatabricksTypingDedupingTest, add override val manyStreamCount = 200 + run the testManyStreamsCompletion test case. Probably not worth actually committing that to git, but would at least verify that there isn't some other bug downstream from here.
(new CDK has an equivalent to this, but databricks is still on the old CDK)
There was a problem hiding this comment.
Should we add a test case here?
There was a problem hiding this comment.
There is already a test that runs a lot o stream (20 atm) I will be running a test locally with 300 streams, but as Ed mentioned, it is probably not a good idea to put that change in the repo
e733c94 to
bb30fc5
Compare
|
What
Since we are hitting an issue because we can only pass 256 parameters to a query, we need to process the streams in batches to avoid hitting that limit
Can this PR be safely reverted and rolled back?